Skip to content

[PM-35265] Migration Guide Draft: Push Based Event Delivery#198

Merged
lastbestdev merged 11 commits into
mainfrom
dirt/pm-35265
May 29, 2026
Merged

[PM-35265] Migration Guide Draft: Push Based Event Delivery#198
lastbestdev merged 11 commits into
mainfrom
dirt/pm-35265

Conversation

@lastbestdev
Copy link
Copy Markdown
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-35265

📔 Objective

Adds document outlining the expected process the Splunk admin upgrading the Bitwarden Splunk app will need to follow for moving over to push based event delivery.

@lastbestdev lastbestdev requested a review from a team as a code owner April 30, 2026 23:58
@lastbestdev lastbestdev changed the title add migration guide draft [PM-35265] Migration Guide Draft: Push Based Event Delivery Apr 30, 2026
Comment thread docs/migration-guide.md Outdated
Comment thread docs/migration-guide.md Outdated
Comment thread docs/migration-guide.md Outdated
Comment thread docs/migration-guide.md Outdated
Comment thread docs/migration-guide.md Outdated
@lastbestdev lastbestdev requested a review from Banrion May 6, 2026 18:29
Copy link
Copy Markdown
Contributor

@Banrion Banrion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace the TODO with the setup page note and this is good to go!

Comment thread docs/migration-guide.md Outdated

Last, it is important to ensure any remaining polling configurations are removed from the application. This prevents the retrieval of duplicate event logs for the Organization, and should be completed as soon as possible. When both poll and push configurations are enabled for an Organization at the same time, the same events will be ingested twice.

[TODO: clarify on how we would like to build disabling polling configurations. should the admin delete them manually (i.e. button click), or should completing push based delivery delete polling configurations automatically?)]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this todo. The instructions here should cover the disabling the polling by going to the Bitwarden Event Logs Splunk app setup page and selecting the appropriate setting (see the splunk setup page documentation on how we are expecting to add the setting via a checkbox)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sounds to me like we will be automatically disabling polling if the setup form is completed for pushing. I have updated the section to reflect this. Let me know if this isn't quite what you were envisioning.

@lastbestdev lastbestdev requested a review from Banrion May 14, 2026 20:14
@Banrion Banrion added the ai-review Request a Claude code review label May 26, 2026
@Banrion
Copy link
Copy Markdown
Contributor

Banrion commented May 26, 2026

@claude Please review

Comment thread docs/migration-guide.md Outdated
Comment on lines +11 to +12
1. Update the Bitwarden Splunk application
2. Complete set up for event push delivery
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 I think it would be worth it to breakdown the Complete setup into two sections to cover the Bitwarden Admin console step and the Bitwarden Event logs separately so it's more clear that the steps are completed in different locations. Though, this would require a change to the sections.

Suggested change
1. Update the Bitwarden Splunk application
2. Complete set up for event push delivery
1. Update the Bitwarden Splunk application
2. Bitwarden Admin Console: Complete set up for event push delivery
3. Bitwarden Event Logs Splunk App: Complete setup

Suggestion of content for 2. Bitwarden Admin Console: Complete set up for event push delivery

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Banrion I swapped the order of the last two steps here. Since the setup flow will start in the Splunk application and be finished in the Admin Console, I think that order makes more sense.

Comment thread docs/migration-guide.md Outdated

The admin will complete this form, and the Bitwarden platform will begin to push event logs for the Organization into Splunk.

**Note that completing the setup form for event push delivery (push or poll) will automatically disable any existing polling configuration.** For example, if your existing configuration uses polling to retrieve events, completing the setup form for event push delivery will overwrite the old polling configuration. Having both event polling and push configurations is not allowed, in order to prevent the same events from being received in Splunk multiple times.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ Ambiguity note. The note reads like checking polling in the setup will disable polling altogether. There won't be a way to complete the setup form for event push delivery AND polling as noted in the example. Specifically the "(push or poll)" is confusing.

I suggest making a new section after Migration Steps to cover this situation:

Important Notes

Event Availability in Splunk

Explanation for when events are pushed or polled, covering when events should appear in Splunk based on the different configurations

Duplicate or Lost Events

Explanation on potential duplicate events, possible lost events if polling is disabled (push driven enabled in the Splunk App first and followed by configuration for push driven events enabled in Admin Console)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added and filled in recommended sections

Comment thread docs/migration-guide.md Outdated
Comment thread docs/migration-guide.md Outdated
Comment thread docs/migration-guide.md Outdated
Comment on lines +11 to +12
1. Update the Bitwarden Splunk application
2. Complete set up for event push delivery
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎨 Link to sections below

lastbestdev and others added 4 commits May 27, 2026 14:01
Co-authored-by: Leslie Tilton <23057410+Banrion@users.noreply.github.com>
Co-authored-by: Leslie Tilton <23057410+Banrion@users.noreply.github.com>
@lastbestdev lastbestdev requested a review from Banrion May 28, 2026 21:11
Banrion
Banrion previously approved these changes May 29, 2026
Copy link
Copy Markdown
Contributor

@Banrion Banrion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Todo comments will be updated with links when available.

Comment thread docs/migration-guide.md Outdated

Take note of both the HEC endpoint and authentication token, and proceed to the next step where push delivery is configured in the Bitwarden Admin Console.

### Bitwarden Admin Console: Complete set up for event push delivery
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤏 Minor note that this "set up" is inconsistent with "setup" used in other parts of the doc.

@lastbestdev lastbestdev enabled auto-merge (squash) May 29, 2026 20:37
@lastbestdev lastbestdev requested a review from Banrion May 29, 2026 20:37
@lastbestdev lastbestdev merged commit 646a108 into main May 29, 2026
7 checks passed
@lastbestdev lastbestdev deleted the dirt/pm-35265 branch May 29, 2026 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants