-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[PM-37084] Business Aware Schedule Recovery and Cancellation #7686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sbrown-livefront
wants to merge
35
commits into
main
Choose a base branch
from
billing/pm-37084/business-aware-schedule-recovery
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
23b2951
feat(billing): introduce unified subscription price increase scheduleβ¦
sbrown-livefront af04330
feat(billing): implement unified subscription price increase scheduleβ¦
sbrown-livefront 18f84c7
refactor(billing): update subscription handlers to use unified scheduler
sbrown-livefront 67eede5
feat(billing): extend price migration feature flag checks
sbrown-livefront 2fdfacb
test(billing): add and update tests for unified price increase scheduler
sbrown-livefront ff70af0
fix(billing): run dotnet format
sbrown-livefront 33910be
Merge branch 'main' into billing/pm-37084/business-aware-schedule-recβ¦
sbrown-livefront 7d424f9
Merge branch 'main' into billing/pm-37084/business-aware-schedule-recβ¦
sbrown-livefront 12c7b8b
Merge branch 'main' into billing/pm-37084/business-aware-schedule-recβ¦
sbrown-livefront b1bb099
feat(billing): expand customer and customer.discount on subscription β¦
sbrown-livefront c4d5f30
refactor(ReinstateSubscriptionCommandTests): rename test method for bβ¦
sbrown-livefront 18ecb4d
feat(billing): expand customer.discount in update handler
sbrown-livefront 365f579
test(billing): update test name
sbrown-livefront 599a5d7
Merge branch 'main' into billing/pm-37084/business-aware-schedule-recβ¦
sbrown-livefront 36bd4d2
feat(billing): add test clock waiting mechanism for upcoming invoices
sbrown-livefront 2cbbac1
feat(billing): introduce cancelling user ID metadata key
sbrown-livefront 1582b86
feat(billing): store cancelling user ID on subscription cancellation
sbrown-livefront 157ead7
feat(billing): clear cancelling user ID on subscription reinstatement
sbrown-livefront 36b3453
test(billing): update subscriber service tests for cancelling user ID
sbrown-livefront 97a2fb4
Merge branch 'main' into billing/pm-37084/business-aware-schedule-recβ¦
sbrown-livefront 68ffb1d
style(SubscriberService): use 'is not null' pattern matching
sbrown-livefront 59ec480
feat(SubscriberService): add PM35215 migration cohort metadata handling
sbrown-livefront cb962e2
feat(SubscriberService): extend price migration deferral to PM35215
sbrown-livefront bcf9fe8
test(SubscriberService): add and update tests for PM35215 feature
sbrown-livefront 3baa358
feat(billing): Introduce OrganizationPriceIncreaseOptions
sbrown-livefront 66a3e8e
refactor(billing): Centralize price increase eligibility in scheduler
sbrown-livefront 59d3c27
refactor(billing): Delegate price increase validation from UpcomingInβ¦
sbrown-livefront 8cdee4c
feat(billing): Manage price increase schedules during subscription liβ¦
sbrown-livefront c9eba37
test(billing): Update UpcomingInvoiceHandlerTests for centralized valβ¦
sbrown-livefront 53cacd7
test(billing): Add PriceIncreaseScheduler tests for SkipIfAlreadyScheβ¦
sbrown-livefront 64bc9ee
test(billing): Add SubscriberService tests for price increase schedulβ¦
sbrown-livefront 4840b16
Merge branch 'main' into billing/pm-37084/business-aware-schedule-recβ¦
sbrown-livefront a0f1caa
fix(billing): run dotnet format
sbrown-livefront eb5f904
fix(billing): remove redundant customer expansion
sbrown-livefront 3babcfe
fix(billing): expand discounts for customer and subscription
sbrown-livefront File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 15 additions & 0 deletions
15
src/Core/Billing/Pricing/OrganizationPriceIncreaseOptions.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| ο»Ώnamespace Bit.Core.Billing.Pricing; | ||
|
|
||
| /// <summary> | ||
| /// Controls optional guard behavior when scheduling an organization price increase via | ||
| /// <see cref="IPriceIncreaseScheduler.ScheduleForSubscription"/>. Guards are applied | ||
| /// during cohort validation before any Stripe calls are made. | ||
| /// </summary> | ||
| public record OrganizationPriceIncreaseOptions | ||
| { | ||
| /// <summary> | ||
| /// Skip scheduling if a price increase has already been scheduled for this | ||
| /// organization (i.e. <c>assignment.ScheduledDate</c> is set). | ||
| /// </summary> | ||
| public bool SkipIfAlreadyScheduled { get; init; } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.