Skip to content

[PM-12469] Move remaining Admin Password Reset code to AC team#7680

Merged
eliykat merged 2 commits into
mainfrom
ac/pm-12469/server-admin-password-reset
May 21, 2026
Merged

[PM-12469] Move remaining Admin Password Reset code to AC team#7680
eliykat merged 2 commits into
mainfrom
ac/pm-12469/server-admin-password-reset

Conversation

@eliykat
Copy link
Copy Markdown
Member

@eliykat eliykat commented May 20, 2026

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-12469

📔 Objective

Moves the remaining Admin Password Reset files into the AdminConsole team's folder structure (no behavior changes):

  • OrganizationUserResetPasswordRequestModelApi/AdminConsole/Models/Request/Organizations/
  • AdminResetPasswordViewModelCore/AdminConsole/Models/Mail/
  • OrganizationUser_ReadManyAccountRecoveryDetailsByOrganizationUserIds.sqlSql/dbo/AdminConsole/Stored Procedures/

Updates affected using/namespace references accordingly.

@eliykat eliykat added the ai-review Request a Claude code review label May 20, 2026
@eliykat eliykat changed the title [PM-12469] refactor: Move remaining Admin Password Reset code to AC team [PM-12469] Move remaining Admin Password Reset code to AC team May 20, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 20, 2026

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Pure file-move refactor relocating the remaining Admin Password Reset assets into the AdminConsole team's folder structure. OrganizationUserResetPasswordRequestModel, AdminResetPasswordViewModel, and the OrganizationUser_ReadManyAccountRecoveryDetailsByOrganizationUserIds stored procedure are moved with their namespaces updated, and the four dependent files (OrganizationUsersController, the integration test, the unit test, and the rename-target source files) have their using directives adjusted accordingly. HandlebarsMailService already references the new Bit.Core.AdminConsole.Models.Mail namespace, BaseMailModel is correctly imported into the relocated view model, and Sql.sqlproj picks up the moved stored procedure via globbing. No behavioral changes; no dangling references to the prior namespaces for any of the moved types.

Code Review Details

No findings.

@eliykat eliykat marked this pull request as ready for review May 20, 2026 05:57
@eliykat eliykat requested review from a team as code owners May 20, 2026 05:57
@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.86%. Comparing base (b848298) to head (2523f2e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7680   +/-   ##
=======================================
  Coverage   64.86%   64.86%           
=======================================
  Files        2140     2140           
  Lines       94629    94629           
  Branches     8445     8445           
=======================================
+ Hits        61377    61378    +1     
+ Misses      31156    31155    -1     
  Partials     2096     2096           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JimmyVo16
JimmyVo16 previously approved these changes May 20, 2026
mkincaid-bw
mkincaid-bw previously approved these changes May 20, 2026
@eliykat eliykat enabled auto-merge (squash) May 20, 2026 20:49
@eliykat eliykat dismissed stale reviews from mkincaid-bw and JimmyVo16 via 2523f2e May 21, 2026 21:21
@eliykat eliykat requested review from JimmyVo16 and mkincaid-bw and removed request for a team and ike-kottlowski May 21, 2026 21:22
@eliykat eliykat merged commit d903096 into main May 21, 2026
45 of 46 checks passed
@eliykat eliykat deleted the ac/pm-12469/server-admin-password-reset branch May 21, 2026 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants