[PM-39704] fix(send): restore increment/decrement buttons for max access count

[harikrishna2208]

Tracking

Fixes #21504

📔 Objective

The rewritten Send UI was missing the +/- increment/decrement buttons on
the "Maximum access count" input that existed in the previous Send UI.

Changes:

• Added ⊖ / ⊕ icon buttons (bwi-minus-circle / bwi-plus-circle)
  as suffix controls on the max access count input
• Added incrementMaxAccessCount() and decrementMaxAccessCount() methods;
  decrement floors at 1 to match Validators.min(1)
• Used type="text" inputmode="numeric" instead of type="number" to
  avoid the browser-native spinner conflicting with the custom buttons
• Split @if (editing()) into two blocks to fix Angular NG8011 content
  projection warnings
• Added i18n keys to all three consuming apps (web, browser, desktop)
• Added unit tests: button visibility, increment, decrement, floor-at-1

📷 Screenshots

✅ Testing

• npm run lint:fix — 0 errors
• npm run prettier — clean
• npm run test:types — all passed
• Unit tests — 12/12 pass
• Manually verified at localhost:8080:
  • Buttons visible in edit mode only ✓
  • Increment adds 1 ✓
  • Decrement subtracts 1 ✓
  • Decrement does not go below 1 ✓

[bitwarden-bot]

Thank you for your contribution! We've added this to our internal tracking system for review.
ID: PM-39704
Link: https://bitwarden.atlassian.net/browse/PM-39704

Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process.

[harr1424]

Hi @harikrishna2208 and thanks for your contribution! The first step in our Community Contribution Review Process is review by our internal product team. This will ensure that the functionality you propose to restore wasn't removed intentionally. If everything checks out, myself or someone on my team will perform an engineering review. Thanks again for your contribution, and please feel free to tag me here if you would an update throughout the process.

[pamperer562580892423]

Thanks for tackling this issue! I'm just another user - and reported this issue.

I just saw your suggestion:

 

And personally, I think I could be fine with these + / - buttons. I just wanted to throw in here, that other similar elements, e.g. in the browser extension, look like this:

 

And I can imagine, the BW design team wants to have a consistent design.

PS: Your buttons do look more like the + / - buttons e.g. the Android mobile app uses. The same "max access count" option looks like this there:

[harikrishna2208]

Thanks @pamperer562580892423 for the context and the screenshots! I went with bwi-minus-circle / bwi-plus-circle since those are the icon variants available in the shared icon font used by this component. Happy to update the design to match whichever style the product/design team prefers once they complete their review.