Skip to content

reduce select label font size#21525

Merged
BryanCunningham merged 1 commit into
mainfrom
uif/fix-select-label-font-size
Jun 26, 2026
Merged

reduce select label font size#21525
BryanCunningham merged 1 commit into
mainfrom
uif/fix-select-label-font-size

Conversation

@BryanCunningham

Copy link
Copy Markdown
Contributor

🎟️ Tracking

📔 Objective

Change select label font size 16 => 14

📸 Screenshots

@BryanCunningham BryanCunningham requested a review from a team as a code owner June 26, 2026 18:06
@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed a single-line UI refinement in the select component template that reduces the option label font size from 16px to 14px. The change applies the bitTypography="body2" directive (!tw-text-sm) and an explicit tw-leading-5 line height, consistent with the sibling description element's use of bitTypography="helper". No security, correctness, or breaking-change concerns were found, and the size hierarchy between label and description is preserved.

Code Review Details

No findings. The change follows established conventions: it uses the existing typography directive rather than ad-hoc classes, and tw-leading-5 is a standard Tailwind token (no arbitrary-value or tw- prefix violations).

@sonarqubecloud

Copy link
Copy Markdown

@BryanCunningham BryanCunningham added the t:bugfix Change Type - Bugfix label Jun 26, 2026
@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.32%. Comparing base (9308412) to head (63f0a1e).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #21525   +/-   ##
=======================================
  Coverage   49.32%   49.32%           
=======================================
  Files        4096     4096           
  Lines      128872   128872           
  Branches    19780    19780           
=======================================
+ Hits        63565    63569    +4     
+ Misses      60596    60592    -4     
  Partials     4711     4711           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BryanCunningham BryanCunningham merged commit 04c246b into main Jun 26, 2026
131 of 133 checks passed
@BryanCunningham BryanCunningham deleted the uif/fix-select-label-font-size branch June 26, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t:bugfix Change Type - Bugfix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants