[PM-39387] fix: Auto-sync premium status after returning from Stripe checkout

[cyprain-okeke]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-39387

📔 Objective

Premium status was not reflected in the client after a user completed payment in an external Stripe checkout flow. The server sends a one-time PremiumStatusChanged push, but the client misses it while it is in the background during checkout — so the user's premium entitlements don't appear until a later full sync.

This PR recovers the missed push by syncing when the client returns from checkout:

• Adds PremiumCheckoutPendingService (abstraction + DefaultPremiumCheckoutPendingService) backed by a memory-scoped, account-scoped state flag (clearOn: ["logout"]).
• PremiumUpgradeDialogComponent marks checkout as pending when it launches the external Stripe checkout URI.
• Desktop consumes the flag on windowIsFocused and browser popup consumes it on init, triggering fullSync(true) to pull the updated premium status.
• Registered the service in jslib-services.module.ts (Angular clients) and service-container.ts (CLI).
• Adds unit tests for the new service and the browser/desktop/dialog wiring.

[github-actions]

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the new PremiumCheckoutPendingService (abstraction, Default implementation, and memory-scoped state key), its DI registration in jslib-services.module.ts and the CLI service-container.ts, and the browser-popup / desktop / dialog wiring that marks and consumes the pending flag. The implementation correctly recovers the missed one-time PremiumStatusChanged push by triggering a single fullSync(true) on return from checkout.

Code Review Details

No blocking findings.

Notable strengths verified during review:

• consumeCheckoutPending reads and clears the flag atomically inside a single update(...), so repeated windowIsFocused events sync at most once (pinned by the desktop "syncs only once across repeated window focus events" test).
• All three consumers fail closed — errors are logged and never block ngOnInit or the dialog flow, and a failed markCheckoutLaunched still launches checkout without showing an error toast.
• State is correctly memory-scoped (BILLING_MEMORY) and account-scoped with clearOn: ["logout"], with a unit test pinning that contract so flipping to disk storage fails loudly.
• DI registration follows conventions: safeProvider in the Angular module and constructor injection in the non-Angular CLI container.

[codecov]

Codecov Report

❌ Patch coverage is 80.70175% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.53%. Comparing base (3779492) to head (b735f1d).
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...dialog/premium-upgrade-dialog.component.stories.ts	0.00%	4 Missing ⚠️
...upgrade-dialog/premium-upgrade-dialog.component.ts	80.00%	0 Missing and 2 partials ⚠️
libs/angular/src/services/jslib-services.module.ts	0.00%	2 Missing ⚠️
...ctions/account/premium-checkout-pending.service.ts	0.00%	1 Missing ⚠️
libs/common/src/billing/abstractions/index.ts	0.00%	1 Missing ⚠️
...services/account/premium-checkout-pending.state.ts	66.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #21518      +/-   ##
==========================================
+ Coverage   49.32%   49.53%   +0.20%     
==========================================
  Files        4096     4099       +3     
  Lines      128872   128928      +56     
  Branches    19780    19786       +6     
==========================================
+ Hits        63564    63861     +297     
+ Misses      60597    60350     -247     
- Partials     4711     4717       +6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[sbrown-livefront]

✅ Looks good. Great thorough job ✨ 🧹 . Have these been manually tested for both?