PM-38122 resolved fastmail checkbox

[bmbitwarden]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-38122

📔 Objective

Add checkbox to Generator page to specify Fastmail website prefix

📸 Screenshots

[github-actions]

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the Fastmail website-prefix feature: the new prefix checkbox in ForwarderSettingsComponent, the sentinel-string↔boolean conversions, the prefixEnabled() helper on ForwarderContext, the emailPrefix derivation in the Fastmail integration, and the i18n keys across all four apps. The previously reported CRITICAL (null from Utils.getDomain crashing .toLowerCase()) is resolved via the ?? "" guard, and tests now cover the prefix-enabled-but-empty-website case. The emailPrefix transformation (lowercase, replace non-compliant chars with _, collapse runs, truncate to 64) matches Fastmail's documented constraints.

Code Review Details

No outstanding findings. The previously flagged CRITICAL on libs/tools/generator/core/src/integration/fastmail.ts is resolved and verified.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.33%. Comparing base (095beec) to head (375c841).
⚠️ Report is 33 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #21465      +/-   ##
==========================================
+ Coverage   49.31%   49.33%   +0.01%     
==========================================
  Files        4085     4096      +11     
  Lines      128373   128874     +501     
  Branches    19681    19779      +98     
==========================================
+ Hits        63306    63574     +268     
- Misses      60387    60589     +202     
- Partials     4680     4711      +31     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[mcamirault]

One change needed so the behavior matches the description

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud