Skip to content

[PM-39293] Remove v2 naming from account recovery dialog#21386

Merged
eliykat merged 1 commit into
mainfrom
ac/pm-39293/remove-account-recovery-v2-naming
Jun 19, 2026
Merged

[PM-39293] Remove v2 naming from account recovery dialog#21386
eliykat merged 1 commit into
mainfrom
ac/pm-39293/remove-account-recovery-v2-naming

Conversation

@eliykat

@eliykat eliykat commented Jun 19, 2026

Copy link
Copy Markdown
Member

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-39293

📔 Objective

Drop the v2 suffix from the new account recovery component. The old version was already removed when the feature flag was removed.

📸 Screenshots

@eliykat eliykat requested a review from a team as a code owner June 19, 2026 04:27
@eliykat eliykat added the ai-review Request a Claude code review label Jun 19, 2026
@eliykat eliykat requested a review from BTreston June 19, 2026 04:27
@github-actions

github-actions Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR is a pure rename refactor dropping the v2 suffix from the account recovery dialog. It renames the component files, selector (app-account-recovery-dialog), class (AccountRecoveryDialogComponent), templateUrl, JSDoc, barrel export, and all consumers including the member dialog manager service and its spec. The rename is complete and consistent — no lingering references to the old V2 names remain, there are no selector or class-name collisions, and the existing README already aligns with the new name.

Code Review Details

No findings.

@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Jun 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.20%. Comparing base (d8711f3) to head (168df82).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #21386   +/-   ##
=======================================
  Coverage   49.20%   49.20%           
=======================================
  Files        4074     4074           
  Lines      127811   127811           
  Branches    19565    19565           
=======================================
+ Hits        62891    62892    +1     
+ Misses      60267    60266    -1     
  Partials     4653     4653           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eliykat eliykat enabled auto-merge (squash) June 19, 2026 05:07
@eliykat eliykat merged commit db97c98 into main Jun 19, 2026
69 of 72 checks passed
@eliykat eliykat deleted the ac/pm-39293/remove-account-recovery-v2-naming branch June 19, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants