[PM-38210] Remove access-intelligence-trend-chart feature flag

[lastbestdev]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-38210

📔 Objective

Unwind the pm-26961-access-intelligence-trend-chart feature flag, which has completed rollout. The trend chart on the Access Intelligence activity dashboard is now permanently enabled.

Changes:

• Removed AccessIntelligenceTrendChart from FeatureFlag enum and DefaultFeatureFlagValue (libs/common/src/enums/feature-flag.enum.ts).
• activity-tab.component (v2) and all-activity.component: removed the flag gate so the trend widget always renders; the RiskOverTimeService is now initialized unconditionally when the organization id is available.
• Removed the now-dead "extend password widget to two columns" layout code (extendPasswordChangeWidget / setExtendPasswordWidget and the NgClass usage) that only existed in the flag-off layout branch.
• Removed the flag plumbing from the Storybook trend-chart mock helper (flagEnabled option + ConfigService provider) and renamed the TrendChartEnabled story to TrendChart.
• Updated activity-tab.component.spec.ts to drop the flag-based tests and assert the trend chart initializes on init and re-initializes when the organization id changes.

The shared AllActivitiesService.extendPasswordChangeWidget$ observable and the child PasswordChangeMetricV2Component.extendWidget output were left in place as they are existing public APIs outside the scope of this flag.

📸 Screenshots

N/A — no net visual change for users who already had the flag enabled.

⏰ Reminders before review

• Contributor guidelines followed
• All required comments/documentation added
• All applicable validations passed

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🔧 (:wrench:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR unwinds the pm-26961-access-intelligence-trend-chart feature flag, making the Access Intelligence trend chart permanently enabled. I reviewed the v1 (all-activity) and v2 (activity-tab) components, the updated spec, Storybook mocks, and the FeatureFlag enum removal. The flag is fully removed with no lingering references, dead layout code (extendPasswordChangeWidget / setExtendPasswordWidget / NgClass) is cleanly excised, and the RiskOverTimeService initialization now correctly runs on the required organizationId input. No security, correctness, or breaking-change concerns surfaced.

Code Review Details

No findings. The flag removal is complete and consistent across both component versions, the updated tests properly exercise the new on-init and org-id-change initialization paths, and the intentionally retained extendWidget output / extendPasswordChangeWidget$ observable (documented in the PR description as out-of-scope public APIs) are harmless no-ops.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

❌ Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.20%. Comparing base (5a34909) to head (7b499dd).
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...ss-intelligence/activity/all-activity.component.ts	0.00%	1 Missing ⚠️
.../v2/activity-tab/activity-tab.component.stories.ts	0.00%	1 Missing ⚠️
...lligence/v2/activity-tab/activity-tab.component.ts	50.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #21376   +/-   ##
=======================================
  Coverage   49.20%   49.20%           
=======================================
  Files        4074     4074           
  Lines      127810   127788   -22     
  Branches    19565    19563    -2     
=======================================
- Hits        62889    62879   -10     
+ Misses      60266    60254   -12     
  Partials     4655     4655           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.