Skip to content

[PM-3841] - Default the new collection organization select to the active org#21374

Open
jaasen-livefront wants to merge 1 commit into
mainfrom
PM-3841
Open

[PM-3841] - Default the new collection organization select to the active org#21374
jaasen-livefront wants to merge 1 commit into
mainfrom
PM-3841

Conversation

@jaasen-livefront

Copy link
Copy Markdown
Collaborator

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-3841

📔 Objective

📸 Screenshots

Screen.Recording.2026-06-17.at.4.49.44.PM.mov

@jaasen-livefront jaasen-livefront requested a review from a team as a code owner June 18, 2026 19:28
@github-actions

github-actions Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the change to VaultComponent.addCollection() that defaults the new-collection organization select to the active vault filter's organization, plus the accompanying unit tests and a test-only ScrollLayoutService setup. The new logic mirrors the existing item-creation pattern, correctly falls back to the first eligible organization, and the eligibleOrganizations[0] access remains safe because the add-collection action is gated behind canCreateCollections (the same eligibility filter). Test coverage exercises all four branches.

Code Review Details

No findings. The change is small, well-scoped, and consistent with existing conventions in the component.

@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.21%. Comparing base (3a45a88) to head (ec471aa).
⚠️ Report is 19 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21374      +/-   ##
==========================================
- Coverage   49.27%   49.21%   -0.07%     
==========================================
  Files        4063     4073      +10     
  Lines      127470   127789     +319     
  Branches    19488    19562      +74     
==========================================
+ Hits        62816    62890      +74     
- Misses      60000    60245     +245     
  Partials     4654     4654              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant