Skip to content

[PM-34491] Address Targeting Rules implementation gaps#21364

Draft
jprusik wants to merge 3 commits into
mainfrom
pm-34491-refactor
Draft

[PM-34491] Address Targeting Rules implementation gaps#21364
jprusik wants to merge 3 commits into
mainfrom
pm-34491-refactor

Conversation

@jprusik

@jprusik jprusik commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

🎟️ Tracking

PM-34491

📔 Objective

📸 Screenshots

@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.50725% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.20%. Comparing base (39a2655) to head (fd0cb12).
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ofill/services/collect-autofill-content.service.ts 89.65% 1 Missing and 5 partials ⚠️
...ofill/services/autofill-overlay-content.service.ts 50.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21364      +/-   ##
==========================================
- Coverage   49.20%   49.20%   -0.01%     
==========================================
  Files        4071     4073       +2     
  Lines      127741   127809      +68     
  Branches    19550    19570      +20     
==========================================
+ Hits        62860    62892      +32     
- Misses      60229    60262      +33     
- Partials     4652     4655       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jprusik jprusik changed the title [PM-34491] [PM-34491] Address Targeting Rules implementation gaps Jun 18, 2026
@bw-ghapp

bw-ghapp Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

⚠️ Changes in this PR impact the Autofill experience of the browser client ⚠️

BIT has tested the core experience with these changes and the feature flag configuration used by vault.bitwarden.com

Caution

Unfortunately, one or more of these tests failed. 😞

Please resolve the failure before merging; reach out to @bitwarden/team-autofill-dev if you'd like help.

You can view the detailed results of the tests here.

@bw-ghapp

bw-ghapp Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

⚠️ Changes in this PR impact the Autofill experience of the browser client ⚠️

BIT has tested the core experience with these changes and all feature flags disabled.

Caution

Unfortunately, one or more of these tests failed. 😞

Please resolve the failure before merging; reach out to @bitwarden/team-autofill-dev if you'd like help.

You can view the detailed results of the tests here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant