Change to global environment for all pre-auth uses#21350
Draft
trmartin4 wants to merge 1 commit into
Draft
Conversation
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #21350 +/- ##
==========================================
- Coverage 49.27% 49.27% -0.01%
==========================================
Files 4063 4063
Lines 127470 127470
Branches 19488 19488
==========================================
- Hits 62816 62813 -3
- Misses 60000 60003 +3
Partials 4654 4654 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-39218
📔 Objective
In #20495, we moved to use the non-user-scoped globalEnvironment$ on the environment selector, to address a race condition on logout that was preventing the correct environment from being used.
We have observed in subsequent tickets that the same issue is now occurring elsewhere in a pre-authenticated state - components and services that execute before the user has authenticated still rely on environment$, and when that is not present (due to the same race condition as #20495) other downstream issues occur.
environment$withuserEnvironment$(userId), which would force by API that a user be present (aka logged in), but until then we are in a position where this could be re-introduced anywhere beyond the pre-auth boundary.This PR makes the change to
globalEnvironment$in the following places:📸 Screenshots