Skip to content

[PM-27844] Set email on sync#21349

Draft
ike-kottlowski wants to merge 11 commits into
mainfrom
auth/pm-27844/set-email-on-sync-v2
Draft

[PM-27844] Set email on sync#21349
ike-kottlowski wants to merge 11 commits into
mainfrom
auth/pm-27844/set-email-on-sync-v2

Conversation

@ike-kottlowski

Copy link
Copy Markdown
Contributor

🎟️ Tracking

PM-27844

📔 Objective

Once email and salt are separated and this feature flag is enabled there's no longer a need to log a user out. So we will sync on the server push service which will set the sync settings service to fire.

📸 Screenshots

@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.64935% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.25%. Comparing base (4ca379e) to head (b0c6af3).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...src/app/auth/settings/account/profile.component.ts 10.81% 33 Missing ⚠️
...pp/auth/settings/account/change-email.component.ts 91.42% 2 Missing and 1 partial ⚠️
...s/common/src/platform/sync/default-sync.service.ts 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21349      +/-   ##
==========================================
- Coverage   49.25%   49.25%   -0.01%     
==========================================
  Files        4079     4079              
  Lines      128049   128072      +23     
  Branches    19608    19612       +4     
==========================================
+ Hits        63071    63080       +9     
- Misses      60319    60331      +12     
- Partials     4659     4661       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bw-ghapp

bw-ghapp Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Changes in this PR impact the Autofill experience of the browser client

BIT has tested the core experience with these changes and all feature flags disabled.

✅ Fortunately, these BIT tests have passed! 🎉

@bw-ghapp

bw-ghapp Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Changes in this PR impact the Autofill experience of the browser client

BIT has tested the core experience with these changes and the feature flag configuration used by vault.bitwarden.com.

✅ Fortunately, these BIT tests have passed! 🎉

@ike-kottlowski ike-kottlowski added the t:feature Change Type - Feature Development label Jun 23, 2026
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t:feature Change Type - Feature Development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant