[PM-37808] Bulk Selection + Batch Bar for Desktop by nick-livefront · Pull Request #21308 · bitwarden/clients

nick-livefront · 2026-06-16T17:01:57Z

🎟️ Tracking

📔 Objective

Wires up the vault batch bar (multi-select) for the desktop vault behind the PM37785_VaultBatchBar and PM37785_DesktopVaultBatchBar feature flags.

Includes a desktop-specific BulkDeleteDialogDesktopComponent because the collection deletion logic imports CollectionService from @bitwarden/admin-console, which libs/vault cannot depend on. This prevents the web dialog from being refactored into a shared location, so each app provides its own implementation via the BULK_DELETE_DIALOG injection token.

📸 Screenshots

Screen.Recording.2026-06-24.at.1.18.56.PM.mov

github-actions · 2026-06-16T17:03:50Z

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the desktop bulk-selection batch bar wiring behind the PM37785_VaultBatchBar and PM37785_DesktopVaultBatchBar feature flags, the new BulkDeleteDialogDesktopAdapter / AssignCollectionsDesktopDialogAdapter, the selection logic in vault-list.component.ts, and the locale additions across browser/web/desktop. The desktop adapters faithfully mirror the already-reviewed web adapters, the feature flags exist and correctly gate the UI, and the new checkbox rows have test coverage.

Code Review Details

No new findings. The two previously posted findings (collections silently dropped; British spelling) were addressed by the author, and the remaining open threads reflect intentional desktop behavior (cipher-only "select all", local-state cleanup after backend deletion) confirmed in discussion.

Notes considered and intentionally not raised as findings:

The new { provide: ... } entries in vault.component.ts use raw provider objects rather than safeProvider(), but this matches the file's existing provider convention.
confirmAndDeleteMixed and the delete copy strings are an exact copy of the approved web adapter; consistency is preferred over divergence here.

codecov · 2026-06-16T17:16:26Z

Codecov Report

❌ Patch coverage is 2.77778% with 105 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.28%. Comparing base (b1487da) to head (4cb083c).
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...tion-dialogs/bulk-delete-dialog-desktop.adapter.ts	0.00%	58 Missing ⚠️
...top/src/vault/app/vault-v3/vault-list.component.ts	0.00%	20 Missing ⚠️
...alogs/assign-collections-desktop-dialog.adapter.ts	0.00%	10 Missing ⚠️
.../desktop/src/vault/app/vault-v3/vault.component.ts	0.00%	9 Missing ⚠️
...t-v3/vault-items/vault-collection-row.component.ts	0.00%	5 Missing ⚠️
libs/vault/src/services/vault-batch-bar.service.ts	0.00%	0 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #21308      +/-   ##
==========================================
- Coverage   49.32%   49.28%   -0.04%     
==========================================
  Files        4096     4098       +2     
  Lines      128869   128974     +105     
  Branches    19776    19814      +38     
==========================================
+ Hits        63567    63568       +1     
- Misses      60592    60692     +100     
- Partials     4710     4714       +4

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jaasen-livefront

Looks great! Just a couple comments. ;)

jaasen-livefront · 2026-06-22T20:00:46Z

+    if (this.collections.length) {
+      const userId = await firstValueFrom(this.accountService.activeAccount$.pipe(getUserId));
+      await this.collectionService.delete(
+        this.collections.map((c) => c.id as CollectionId),
+        userId,
+      );
+      this.toastService.showToast({
+        variant: "success",
+        message: this.i18nService.t("deletedCollections"),
+      });
+    }


❓ Is this necessary since we're already awaiting the deleteCollections above?

Yes it is, a tad bit confusing. It's identical to the web implementation here. The first set of promises is deleting them from the backend and this block here is removing them from the local state.

jaasen-livefront · 2026-06-22T20:04:52Z

+                type="checkbox"
+                bitCheckbox
+                [disabled]="disabled() || isEmpty()"
+                (change)="$event ? toggleAll() : null"


🎨 I believe $event is always truthy so this check shouldn't be required.

jaasen-livefront · 2026-06-22T20:18:08Z

+    return cipherItems.length > 0 && cipherItems.every((i) => this.selection.isSelected(i));
+  }
+
+  protected toggleAll(): void {


❓ Just to verify we only want to select ciphers here not collections?

Correct, on the desktop there isn't a view that shows you only collections like there is on the web vault. This is more defensive than anything.

gbubemismith · 2026-06-23T01:35:05Z

I think we can use the opportunity to align to the new dialog designs. I already started with this for the web e1868e7

Added e7fd8c2. You have BulkDeleteService in the apps/web, could it be moved to libs/vault so that I could reuse that as well?

Yeah that makes sense

Moved here 4964f6a

…p-vault-export

claude · 2026-06-24T15:50:38Z

+  protected readonly submit = async () => {
+    const deletePromises: Promise<void>[] = [];
+
+    if (this.unassignedCiphers.length && this.organization?.canEditUnassignedCiphers) {
+      deletePromises.push(this.deleteCiphersAdmin(this.unassignedCiphers));
+    }
+    if (this.cipherIds.length) {
+      if (!this.organization || !this.organization.canEditAllCiphers) {
+        deletePromises.push(this.deleteCiphers());
+      } else {
+        deletePromises.push(this.deleteCiphersAdmin(this.cipherIds));
+      }
+    }
+
+    await Promise.all(deletePromises);
+
+    if (this.totalCiphersCount) {
+      this.toastService.showToast({
+        variant: "success",
+        message: this.i18nService.t(this.permanent ? "permanentlyDeletedItems" : "deletedItems"),
+      });
+    }
+    this.close(BulkDeleteDialogResult.Deleted);
+  };


❌ CRITICAL: Selected collections are silently dropped — the dialog reports success but never deletes them.

Details and fix

VaultBatchBarService.bulkDelete() passes collections into this dialog (bulk-delete-dialog.token.ts includes collections?: CollectionView[]), and collection rows are individually selectable on desktop (vault-list.component.html wires (checkboxChange)="selection.toggle(item)" on collection rows, and collectionsToDisplay is populated into the data source). canDelete() evaluates collections too, so the delete action is offered when a collection is selected.

However, this component only handles cipherIds / unassignedCiphers. The collections param is never read or deleted. Result:

Select a collection (with or without ciphers) → click delete → submit runs, ignores collections, returns BulkDeleteDialogResult.Deleted, selection clears and the list refreshes.

If only a collection is selected, totalCiphersCount === 0, so no toast even fires — the user sees the row vanish from the refreshed list region with no error, but the collection still exists on the server.

The web equivalent (apps/web/.../bulk-delete-dialog/bulk-delete-dialog.component.ts) deletes collections via deleteCollections(). The desktop app already imports CollectionService (vault.component.ts:177), so this dialog can implement the same path — read this.dialogData.collections, delete via CollectionService/ApiService.deleteManyCollections, and surface the deletedCollections / collectionsDeleted toast (keys were added in this PR but are currently unused).

Alternatively, if desktop intentionally does not support collection deletion yet, prevent collections from being selectable on desktop so the delete action is never offered for them.

Deletion of collections is not available on the desktop but this was resolved from 267bd0f which implements the same behavior as the web

…p-vault-export

nick-livefront · 2026-06-24T18:21:22Z

@gbubemismith I merged up with main and resolved some of the translation work that you did your branch.

nick-livefront · 2026-06-24T18:22:16Z

-  "copyPrivateKey": {
-    "message": "Copy private key"
-  },
-  "copyPublicKey": {
-    "message": "Copy public key"
-  },
-  "copyFingerprint": {
-    "message": "Copy fingerprint"
-  },


These were duplicate keys in the file

…08/desktop-vault-export

claude · 2026-06-26T16:40:19Z

+    "message": "1 item will be permanently transferred to the selected organization. You will no longer own this item."
+  },
+  "personalItemsTransferWarningPlural": {
+    "message": "$PERSONAL_ITEMS_COUNT$ items will be permanently transferred to the selected organisation. You will no longer own these items.",


🎨 SUGGESTED: British spelling "organisation" is inconsistent with the rest of the en-US locale.

Details and fix

Every other string in this file (and the matching personalItemsTransferWarningPlural key in apps/web/src/locales/en/messages.json:12318) uses the American spelling "organization". This is the only "organisation" in the file.

Suggested change

"message": "$PERSONAL_ITEMS_COUNT$ items will be permanently transferred to the selected organisation. You will no longer own these items.",

"message": "$PERSONAL_ITEMS_COUNT$ items will be permanently transferred to the selected organization. You will no longer own these items.",

This keeps the desktop copy in sync with the web copy for the same key.

…ring

nick-livefront · 2026-06-26T19:22:33Z

@gbubemismith - I addressed Claude's comment: #21308 (comment)

sonarqubecloud · 2026-06-26T19:25:22Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
40.2% Duplication on New Code

See analysis details on SonarQube Cloud

add selection and bulk actions for desktop

534e744

nick-livefront requested a review from a team as a code owner June 16, 2026 17:01

nick-livefront requested a review from jaasen-livefront June 16, 2026 17:01

nick-livefront added the ai-review-vnext Request a Claude code review using the vNext workflow label Jun 16, 2026

jaasen-livefront reviewed Jun 22, 2026

View reviewed changes

gbubemismith reviewed Jun 23, 2026

View reviewed changes

nick-livefront added 4 commits June 23, 2026 09:36

remove event, it's always truthy

e7fd8c2

Merge remote-tracking branch 'origin/main' into vault/pm-37808/deskto…

d434504

…p-vault-export

add space beneath vault list when batch bar is active

d9da21d

lowercase selected in the bulk actions bar

bd7128c

nick-livefront requested a review from a team as a code owner June 23, 2026 15:59

nick-livefront requested review from BryanCunningham, gbubemismith and jaasen-livefront and removed request for jaasen-livefront June 23, 2026 15:59

willmartian self-requested a review June 23, 2026 16:02

nick-livefront added 3 commits June 24, 2026 09:45

update archive messages for bulk dialog

92b35aa

add assign to collection translations

0fd3da8

update deletion dialog for desktop

0523f81

nick-livefront added the t:feature Change Type - Feature Development label Jun 24, 2026

fix translation value change

3f61804

claude Bot reviewed Jun 24, 2026

View reviewed changes

fix translation change in bulk action tests

52ca8d8

gbubemismith previously approved these changes Jun 24, 2026

View reviewed changes

Merge remote-tracking branch 'origin/main' into vault/pm-37808/deskto…

7d2dde3

…p-vault-export

nick-livefront marked this pull request as draft June 24, 2026 17:47

nick-livefront added 2 commits June 24, 2026 13:16

align deletion dialog with web implementation

267bd0f

remove duplicate translation keys

18e4c55

nick-livefront dismissed gbubemismith’s stale review via 18e4c55 June 24, 2026 18:18

nick-livefront requested review from gbubemismith and jaasen-livefront June 24, 2026 18:20

nick-livefront added the desktop Desktop Application label Jun 24, 2026

nick-livefront marked this pull request as ready for review June 24, 2026 18:21

nick-livefront commented Jun 24, 2026

View reviewed changes

BryanCunningham removed request for a team and BryanCunningham June 26, 2026 13:54

Merge branch 'main' of github.com:bitwarden/clients into vault/pm-378…

bf0d6e6

…08/desktop-vault-export

gbubemismith previously approved these changes Jun 26, 2026

View reviewed changes

claude Bot reviewed Jun 26, 2026

View reviewed changes

Fix American spelling in personalItemsTransferWarningPlural locale st…

4cb083c

…ring

nick-livefront dismissed gbubemismith’s stale review via 4cb083c June 26, 2026 19:21

	"message": "$PERSONAL_ITEMS_COUNT$ items will be permanently transferred to the selected organisation. You will no longer own these items.",
	"message": "$PERSONAL_ITEMS_COUNT$ items will be permanently transferred to the selected organization. You will no longer own these items.",

Uh oh!

Conversation

nick-livefront commented Jun 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎟️ Tracking

📔 Objective

📸 Screenshots

Uh oh!

github-actions Bot commented Jun 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤖 Bitwarden Claude Code Review

Uh oh!

codecov Bot commented Jun 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

jaasen-livefront left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

claude Bot Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nick-livefront commented Jun 24, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

claude Bot Jun 26, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nick-livefront commented Jun 26, 2026

Uh oh!

sonarqubecloud Bot commented Jun 26, 2026

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nick-livefront commented Jun 16, 2026 •

edited

Loading

github-actions Bot commented Jun 16, 2026 •

edited

Loading

codecov Bot commented Jun 16, 2026 •

edited

Loading