[PM-39009] Do not do heuristic filtering on targeted fields

[jprusik]

🎟️ Tracking

PM-39009

📔 Objective

Note: split from #20970

Do not do heuristic filtering on targeted fields

[github-actions]

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the change to fillGeneratedPassword in overlay.background.ts, which widens the new-password field filter so targeted fields qualified as newPassword by targeting rules bypass the heuristic isNewPasswordField check. The change is additive — non-targeted fields retain existing heuristic behavior — and the strict field.targeted === true guard plus string-constant comparison are sound. The accompanying spec covers the confirmPassword case that the heuristic misses. No security, correctness, or breaking-change concerns found.

Code Review Details

No findings.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.22%. Comparing base (3ca5564) to head (3e08225).
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #21245   +/-   ##
=======================================
  Coverage   49.22%   49.22%           
=======================================
  Files        4054     4054           
  Lines      126968   126969    +1     
  Branches    19360    19361    +1     
=======================================
+ Hits        62496    62497    +1     
- Misses      59866    59867    +1     
+ Partials     4606     4605    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[bw-ghapp]

Changes in this PR impact the Autofill experience of the browser client

BIT has tested the core experience with these changes and the feature flag configuration used by vault.bitwarden.com.

✅ Fortunately, these BIT tests have passed! 🎉

[bw-ghapp]

Changes in this PR impact the Autofill experience of the browser client

BIT has tested the core experience with these changes and all feature flags disabled.

✅ Fortunately, these BIT tests have passed! 🎉