Skip to content

[PM-37955] Update typescript configs#495

Open
jprusik wants to merge 1 commit into
mainfrom
pm-37955
Open

[PM-37955] Update typescript configs#495
jprusik wants to merge 1 commit into
mainfrom
pm-37955

Conversation

@jprusik
Copy link
Copy Markdown
Contributor

@jprusik jprusik commented May 22, 2026

🎟️ Tracking

PM-37955

📔 Objective

Bumping to typescript v6 requires some project config updates to work properly

@jprusik jprusik self-assigned this May 22, 2026
@jprusik jprusik added the ai-review-vnext Request a Claude code review using the vNext workflow label May 22, 2026
@jprusik jprusik requested a review from blackwood May 22, 2026 16:30
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 22, 2026

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR updates the three TypeScript project configs (scripts/, tests/, benchmarks/) in preparation for a TypeScript v6 bump. Changes include switching to node16 module/resolution, making rootDir explicit for the configs that import from sibling project directories, restricting ambient types to what each surface actually needs, and converting commented-out strict placeholders to explicit strict: false with a tracked FIXME ticket. No source code or runtime behavior changes; output layout is preserved because the new explicit rootDir: ".." matches what TypeScript was previously inferring from cross-directory imports (../constants, ../abstractions, ../fixtures).

Code Review Details

No issues identified.

Notes (informational, not findings):

  • tests/tsconfig.json correctly adds "chrome" to types since tests/utils.ts uses chrome.tabs; scripts/ and benchmarks/ omit it as neither references Chrome APIs.
  • rootDir: ".." is only added where needed (tests, benchmarks); scripts/ is self-contained and correctly left without it.
  • The PR description says "Bumping to typescript v6", but the actual bump remains in renovate/typescript-6.x; this PR is config prep only. package.json still pins typescript: 5.9.3, which is intentional.

@jprusik jprusik mentioned this pull request May 22, 2026
1 task
@jprusik jprusik marked this pull request as ready for review May 22, 2026 16:39
@jprusik jprusik requested a review from a team as a code owner May 22, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review-vnext Request a Claude code review using the vNext workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant