You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR updates the three TypeScript project configs (scripts/, tests/, benchmarks/) in preparation for a TypeScript v6 bump. Changes include switching to node16 module/resolution, making rootDir explicit for the configs that import from sibling project directories, restricting ambient types to what each surface actually needs, and converting commented-out strict placeholders to explicit strict: false with a tracked FIXME ticket. No source code or runtime behavior changes; output layout is preserved because the new explicit rootDir: ".." matches what TypeScript was previously inferring from cross-directory imports (../constants, ../abstractions, ../fixtures).
Code Review Details
No issues identified.
Notes (informational, not findings):
tests/tsconfig.json correctly adds "chrome" to types since tests/utils.ts uses chrome.tabs; scripts/ and benchmarks/ omit it as neither references Chrome APIs.
rootDir: ".." is only added where needed (tests, benchmarks); scripts/ is self-contained and correctly left without it.
The PR description says "Bumping to typescript v6", but the actual bump remains in renovate/typescript-6.x; this PR is config prep only. package.json still pins typescript: 5.9.3, which is intentional.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ai-review-vnextRequest a Claude code review using the vNext workflow
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-37955
📔 Objective
Bumping to typescript v6 requires some project config updates to work properly