Skip to content

allow Coldcard EDGE to display singlesig taproot address #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
scgbckbone wants to merge 1 commit into
base: master
Choose a base branch
from
Open

allow Coldcard EDGE to display singlesig taproot address #833

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion hwilib/devices/coldcard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
AF_P2WSH,
AF_P2SH,
AF_P2WSH_P2SH,
AF_P2TR,
)
from .._base58 import (
get_xpub_fingerprint,
Expand Down Expand Up @@ -262,7 +263,9 @@ def display_singlesig_address(
elif addr_type == AddressType.LEGACY:
addr_fmt = AF_CLASSIC
elif addr_type == AddressType.TAP:
raise UnavailableActionError("Coldcard does not support displaying Taproot addresses yet")
if not self.is_edge:
raise UnavailableActionError("Coldcard does not support displaying Taproot addresses yet. Use EDGE.")
addr_fmt = AF_P2TR
else:
raise BadArgumentError("Unknown address type")

Expand Down
Loading