Add AI support for local terminal sessions#419
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6191e20eea
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const POWERSHELL_SHELLS = new Set(["powershell", "powershell.exe", "pwsh", "pwsh.exe"]); | ||
| const CMD_SHELLS = new Set(["cmd", "cmd.exe"]); | ||
| const FISH_SHELLS = new Set(["fish"]); | ||
| const POSIX_SHELLS = new Set(["sh", "bash", "zsh", "ksh", "dash", "ash"]); |
There was a problem hiding this comment.
*
detectShellKind only recognizes bare POSIX names (bash, zsh, fish, etc.) and misses common Windows executables like bash.exe/fish.exe. In that case local sessions are classified as unknown, and the new local-shell guard in AI execution paths rejects all commands for those sessions, so users with Git Bash configured by full path get a hard “unsupported local shell” failure even though the shell is usable.
Useful? React with 👍 / 👎.
* Add AI support for local terminal sessions * Fix local AI session metadata and shell safety * Fix local session cloning and multi-exec errors * Refactor local shell detection helpers * Fix local shell helper import path * Fix CJS imports in renderer * Use ESM local shell helpers in renderer * Normalize local shell paths and platform metadata
1 participant
Summary
Test plan
🤖 Generated with Claude Code