[codex] fix Linux BrowserWindow focusable default#30
Merged
cau1k merged 1 commit intoJul 8, 2026
Merged
Conversation
Member
|
LGTM. Thank you @zhuziqi97 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #29.
This adds a Linux upstream patch contract for the 26.623 BrowserWindow focus regression. Upstream changed the primary window options from omitting undefined
focusableto passingfocusable: undefined; Electron/Linux treats that as an unfocusable window, which can become an unmanaged override-redirect X11 surface and prevents normal input focus.The patch rewrites only the primary BrowserWindow forwarding path from
focusable:mtofocusable:m??!0. Explicitfocusable:falseoverlay/popup windows are preserved.Validation
node --test test/upstream-patches.test.mjs test/smoke-artifacts.test.mjsnpm testpatchUpstreamMainSourcechanges exactly one focusable default and leaves no unguarded focusable forwarding.node scripts/canary.mjs --channel prod --no-smoke --json-output dist/focusable-prod-canary.json26.623.141536, build4753, package26.623.141536-launcher.33node scripts/release-channel.mjs --channel prod --archive .cache/prod/Codex-darwin-arm64-26.623.141536.zip --json-output dist/focusable-prod-build.jsonnode scripts/canary.mjs --channel prod --no-browser --json-output dist/focusable-prod-canary-full.jsonlinux-window-focusable-contractpassed withchecked: 1