Fix Issue #35: get_active_bet_requests endpoint present#66
Open
DanielTomaro13 wants to merge 1 commit intobetcode-org:masterfrom
Open
Fix Issue #35: get_active_bet_requests endpoint present#66DanielTomaro13 wants to merge 1 commit intobetcode-org:masterfrom
DanielTomaro13 wants to merge 1 commit intobetcode-org:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
Fix Issue #35: get_active_bet_requests endpoint present
Just like Issue #33 the get_active_bet_requests endpoint is one that betconnect has deprecated from use. It is still active in order to not break integration for some users as they transition, but we have removed all use from the site and this endpoint is not in our docs. This endpoint should be removed to make sure users don't make this part of their integration and we then remove it from our API. Instead they are urged to use the
my_bets/back/{user_id}/activeendpoint.Fix Issue #56: Unpin pydantic
Is there any reason why pydantic is pinned to pydantic==2.6.4?
Can it not be pinned to this as a minimum version and allow for that and above?
make sure you run black because I think its part of tests
Summary
Summary
This PR addresses two issues:
Issue #35: Removal of deprecated get_active_bet_requests endpoint
Removed the deprecated
get_active_bet_requestsmethod from the betting endpoints as it has been deprecated by BetConnect. Users are now urged to use themy_bets/back/{user_id}/activeendpoint instead. This change includes:get_active_bet_requestsmethod frombetconnect/endpoints/betting.pyActiveBetRequestsand relatedActiveBetclasses frombetconnect/resources/betting.pybetconnect/resources/__init__.pyto remove references to the deprecated classestests/unit/endpoints/test_betting/test_betting.pyIssue #56: Unpinned pydantic version
Changed the pydantic dependency from
pydantic==2.12.3(pinned version) topydantic>=2.12.3(minimum version) inpyproject.toml. This allows users to install pydantic 2.12.3 and above, providing more flexibility for dependency management while maintaining compatibility.Files Changed
betconnect/endpoints/betting.pybetconnect/resources/betting.pybetconnect/resources/__init__.pypyproject.tomltests/unit/endpoints/test_betting/test_betting.py