Skip to content

Fix Issue #35: get_active_bet_requests endpoint present#66

Open
DanielTomaro13 wants to merge 1 commit intobetcode-org:masterfrom
DanielTomaro13:pr-creator-1775694229689
Open

Fix Issue #35: get_active_bet_requests endpoint present#66
DanielTomaro13 wants to merge 1 commit intobetcode-org:masterfrom
DanielTomaro13:pr-creator-1775694229689

Conversation

@DanielTomaro13
Copy link
Copy Markdown

Task

Fix Issue #35: get_active_bet_requests endpoint present

Just like Issue #33 the get_active_bet_requests endpoint is one that betconnect has deprecated from use. It is still active in order to not break integration for some users as they transition, but we have removed all use from the site and this endpoint is not in our docs. This endpoint should be removed to make sure users don't make this part of their integration and we then remove it from our API. Instead they are urged to use the my_bets/back/{user_id}/active endpoint.

Fix Issue #56: Unpin pydantic

Is there any reason why pydantic is pinned to pydantic==2.6.4?

Can it not be pinned to this as a minimum version and allow for that and above?

make sure you run black because I think its part of tests

Summary

Summary

This PR addresses two issues:

Issue #35: Removal of deprecated get_active_bet_requests endpoint
Removed the deprecated get_active_bet_requests method from the betting endpoints as it has been deprecated by BetConnect. Users are now urged to use the my_bets/back/{user_id}/active endpoint instead. This change includes:

  • Removed the get_active_bet_requests method from betconnect/endpoints/betting.py
  • Removed the ActiveBetRequests and related ActiveBet classes from betconnect/resources/betting.py
  • Updated imports in betconnect/resources/__init__.py to remove references to the deprecated classes
  • Removed the corresponding test method in tests/unit/endpoints/test_betting/test_betting.py

Issue #56: Unpinned pydantic version
Changed the pydantic dependency from pydantic==2.12.3 (pinned version) to pydantic>=2.12.3 (minimum version) in pyproject.toml. This allows users to install pydantic 2.12.3 and above, providing more flexibility for dependency management while maintaining compatibility.

Files Changed

  • betconnect/endpoints/betting.py
  • betconnect/resources/betting.py
  • betconnect/resources/__init__.py
  • pyproject.toml
  • tests/unit/endpoints/test_betting/test_betting.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant