Enable beman-tidy (--require-all mode) into beman.indices_view

[neatudarius]

Issue: bemanproject/beman-tidy#256

Enable beman-tidy (--require-all mode) into beman.indices_view

Note: Badge check should be fixed before merge.

[JeffGarland]

@neatudarius I think this is ready? all the tidy checks are passing? @wermos any thoughts?

[wermos]

@wermos any thoughts?

The pre-commit check isn't passing yet:

Running check [Requirement][file.license_id] ... 
[error][file.license_id]: Missing SPDX-License-Identifier in .github/workflows/pre-commit-check.yml. Please add it at the first line. See https://github.com/bemanproject/beman/blob/main/docs/beman_standard.md#filelicense_id
[error][file.license_id]: Missing SPDX-License-Identifier in .markdownlint.yaml. Please add it at the first line. See https://github.com/bemanproject/beman/blob/main/docs/beman_standard.md#filelicense_id
[error][file.license_id]: Missing SPDX-License-Identifier in .pre-commit-config.yaml. Please add it at the first line. See https://github.com/bemanproject/beman/blob/main/docs/beman_standard.md#filelicense_id
[error][file.license_id]: Missing SPDX-License-Identifier in infra/.github/workflows/pre-commit.yml. Please add it at the first line. See https://github.com/bemanproject/beman/blob/main/docs/beman_standard.md#filelicense_id
[error][file.license_id]: Missing SPDX-License-Identifier in infra/.pre-commit-config.yaml. Please add it at the first line. See https://github.com/bemanproject/beman/blob/main/docs/beman_standard.md#filelicense_id
[error][file.license_id]: Missing SPDX-License-Identifier in infra/cmake/BuildTelemetry.cmake. Please add it at the first line. See https://github.com/bemanproject/beman/blob/main/docs/beman_standard.md#filelicense_id
[error][file.license_id]: Missing SPDX-License-Identifier in infra/cmake/BuildTelemetryConfig.cmake. Please add it at the first line. See https://github.com/bemanproject/beman/blob/main/docs/beman_standard.md#filelicense_id
[error][file.license_id]: Missing SPDX-License-Identifier in infra/cmake/telemetry.sh. Please add it at the first line. See https://github.com/bemanproject/beman/blob/main/docs/beman_standard.md#filelicense_id
[error][file.license_id]: Missing SPDX-License-Identifier in infra/cmake/use-fetch-content.cmake. Please add it at the first line. See https://github.com/bemanproject/beman/blob/main/docs/beman_standard.md#filelicense_id
	check [Requirement][file.license_id] ... failed

Some of these (.github/workflows/pre-commit-check.yml, .markdownlint.yaml, .pre-commit-config.yaml) can be fixed in the repo, but the other failures are from infra/, which means the license stuff needs to be added upstream and then we need to update our submodule.

I can handle the missing license IDs in the files in the repo, but I am not familiar with the process for updating the files in the infra/ directory.

[JeffGarland]

I can handle the missing license IDs in the files in the repo, but I am not familiar with the process for updating the files in the infra/ directory.

@wermos I checked and they are fixed upstream in infra now -- so an update is probably in order. Can we fix the other ones and close this out?

[wermos]

Yep, the license issue is fixed.

The only failing check is this:

Running check [Requirement][release.godbolt_trunk_version] ... 
[error][release.godbolt_trunk_version]: The file 'README.md' does not contain a Compiler Explorer badge - trunk version assumed to be missing.
	check [Requirement][release.godbolt_trunk_version] ... failed

I don't think this library is available on Godbolt. What is the intended solution: add this on godbolt or make it so that the lint check doesn't ask for the godbolt badge?

[neatudarius]

Yep, the license issue is fixed.

The only failing check is this:

Running check [Requirement][release.godbolt_trunk_version] ... 
[error][release.godbolt_trunk_version]: The file 'README.md' does not contain a Compiler Explorer badge - trunk version assumed to be missing.
	check [Requirement][release.godbolt_trunk_version] ... failed

I don't think this library is available on Godbolt. What is the intended solution: add this on godbolt or make it so that the lint check doesn't ask for the godbolt badge?

now it is -> https://compiler-explorer.com/z/6cxfs8haa