Depend on web-vitals 2.x - #6
Open
laradevitt wants to merge 1 commit into
Open
Conversation
Author
|
Wups - Would actually be updating from web-vitals |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR for Update web-vitals dependency to 2.x branch #5
With this update there is a breaking change as described in the PR Update CLS to max session window 5s cap 1s gap #148:
AFAICT this plugin only references the performance entry of the TTFB metric to calculate request time so I'm fairly confident this plugin would be unaffected by the breaking change but a proper review is obviously in order.
Thanks!