Fix model discovery fallback parity by beardedeagle · Pull Request #95 · beardedeagle/beam-agent

beardedeagle · 2026-04-09T07:03:13Z

Summary

Fix Copilot model discovery so unhealthy ACP sessions fall back to the CLI prompt path instead of returning empty results.
Make OpenCode model discovery shell-agnostic by using the configured login shell rather than hardcoded shell or path assumptions.
Preserve BeamAgent auth and catalog hardening while aligning OpenCode discovery with the same model list seen from the user's login shell.

Verification

rebar3 compile
rebar3 eunit --module=beam_agent_auth_core_tests,beam_agent_catalog_model_tests,copilot_model_discovery_tests,opencode_model_discovery_tests
mix test test/monkey_claw/agent_bridge/backend/beam_agent_list_models_test.exs test/monkey_claw/model_registry_test.exs test/monkey_claw_web/live/vault_live_test.exs in MonkeyClaw
Live MonkeyClaw.ModelRegistry.refresh_all() verification: claude_count: 3, copilot_count: 15, opencode_count: 444

Notes

Excludes local untracked AGENT_AS_RECORD_DESIGN.md
No agent or plan files were committed

Copilot

Pull request overview

This PR improves model discovery reliability and parity across backends by ensuring unhealthy native sessions fall back to CLI-based probing and by making OpenCode discovery behave like an interactive/login-shell invocation (while keeping BeamAgent’s auth hardening approach).

Changes:

Extend beam_agent_catalog:maybe_fallback_model_list/2 to fallback on native_call_failed timeout/session_error cases.
Add OpenCode auth fallback to opencode auth list parsing when the provider endpoint is unreachable and env auth isn’t present.
Add new CLI runner options (cwd) and a login-shell capture path used by model discovery probes.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
test/public/beam_agent_catalog_model_tests.erl	Adds coverage for fallback behavior on native timeout exits.
test/core/beam_agent_auth_core_tests.erl	Adds tests for OpenCode CLI-auth detection and new CLI runner behaviors (cwd + login shell).
src/public/beam_agent_catalog.erl	Adds fallback parity for `native_call_failed` timeout/session_error tuples.
src/public/beam_agent_auth.erl	Updates public docs to reflect OpenCode auth probing order (provider/env/CLI).
src/core/beam_agent_auth_core.erl	Implements OpenCode CLI-auth fallback, adds `run_capture_cli/4` (cwd), and introduces login-shell capture logic.
src/backends/opencode/opencode_client.erl	Prefers CLI-backed model catalog; switches model CLI probing to login-shell capture.
src/backends/copilot/copilot_client.erl	Gates native model listing on session health and adds a neutral CLI probe cwd.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

beardedeagle

Submitting the draft review created while replying inline so the thread no longer remains pending. The substantive fix details stay in the inline thread reply below.

beardedeagle · 2026-04-09T10:12:35Z

Latest review-wave follow-up landed in 9ec35e5.

Summary:

quote "$HOME/.profile" in the sh-family login-shell fallback helper
remove the redundant Claude config variant expansion path

Verification:

rebar3 eunit --module=beam_agent_auth_core_tests,claude_model_discovery_tests
rebar3 compile
git diff --check

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Fix model discovery fallback parity

546484b

Copilot AI review requested due to automatic review settings April 9, 2026 07:03

Copilot started reviewing on behalf of beardedeagle April 9, 2026 07:04 View session

Copilot AI reviewed Apr 9, 2026

View reviewed changes

Preserve Claude 1m model variants in discovery

4b92487

beardedeagle requested a review from Copilot April 9, 2026 08:06

Copilot started reviewing on behalf of beardedeagle April 9, 2026 08:06 View session

Copilot AI reviewed Apr 9, 2026

View reviewed changes

Comment thread src/core/beam_agent_auth_core.erl

Comment thread src/core/beam_agent_auth_core.erl Outdated

Comment thread src/backends/claude/claude_agent_sdk.erl Outdated

beardedeagle added 3 commits April 9, 2026 03:36

Harden login-shell CLI runner

95e8c28

Address PR review portability follow-ups

30bfc29

Fix CI login-shell regressions

c07b14f

beardedeagle requested a review from Copilot April 9, 2026 08:58

Copilot started reviewing on behalf of beardedeagle April 9, 2026 08:59 View session

Copilot AI reviewed Apr 9, 2026

View reviewed changes

Comment thread src/core/beam_agent_auth_core.erl Outdated

Comment thread src/core/beam_agent_auth_core.erl Outdated

Harden shell env fallback handling

72149ae

beardedeagle requested a review from Copilot April 9, 2026 09:11

Copilot started reviewing on behalf of beardedeagle April 9, 2026 09:11 View session

Copilot AI reviewed Apr 9, 2026

View reviewed changes

Comment thread src/core/beam_agent_auth_core.erl

Comment thread src/core/beam_agent_auth_core.erl

Drain port close and honor backslash paths

5aa7ac2

beardedeagle requested a review from Copilot April 9, 2026 09:40

Copilot started reviewing on behalf of beardedeagle April 9, 2026 09:41 View session

Copilot AI reviewed Apr 9, 2026

View reviewed changes

Comment thread src/core/beam_agent_auth_core.erl Outdated

Comment thread src/core/beam_agent_auth_core.erl Outdated

Improve opencode auth probe fallbacks

ee7e3f8

beardedeagle requested a review from Copilot April 9, 2026 09:53

Copilot AI reviewed Apr 9, 2026

View reviewed changes

Comment thread src/core/beam_agent_auth_core.erl Outdated

Comment thread src/backends/claude/claude_agent_sdk.erl Outdated

Fix latest PR review follow-ups

9ec35e5

beardedeagle commented Apr 9, 2026

View reviewed changes

Comment thread src/backends/claude/claude_agent_sdk.erl Outdated

beardedeagle requested a review from Copilot April 9, 2026 10:09

Copilot started reviewing on behalf of beardedeagle April 9, 2026 10:09 View session

Copilot AI reviewed Apr 9, 2026

View reviewed changes

Comment thread src/core/beam_agent_auth_core.erl Outdated

Clarify login-shell runner docstring

735d962

beardedeagle requested a review from Copilot April 9, 2026 10:18

Copilot started reviewing on behalf of beardedeagle April 9, 2026 10:18 View session

Copilot AI reviewed Apr 9, 2026

View reviewed changes

Comment thread src/backends/opencode/opencode_client.erl

Comment thread src/core/beam_agent_auth_core.erl Outdated

beardedeagle added 3 commits April 9, 2026 05:34

Harden opencode discovery and auth probe status

d3fb12b

Restore opencode shell parity for bare discovery

0933f31

Fix opencode parity typing contract

e703ad4

beardedeagle merged commit f3085e0 into main Apr 9, 2026
9 checks passed

beardedeagle deleted the fix/model-discovery-followups branch April 9, 2026 12:42

Conversation

beardedeagle commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Verification

Notes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

beardedeagle left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

beardedeagle commented Apr 9, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

beardedeagle commented Apr 9, 2026 •

edited

Loading

beardedeagle left a comment •

edited

Loading