[API / Testing / Mode Solver]: Add new simulation, modal solver, and plotting APIs#120
Merged
Conversation
…to include new commands for dead code checks and audits. Replace flake8 and isort with ruff for linting and formatting. Update documentation to reflect changes in development commands and tool configurations. Introduce shared Yee-lattice constants and refactor device classes to utilize runtime state management. Improve error handling and assertions in simulation components.
…guide example parameters and enhance simulation results tests for field and frame aliases.
- Introduced a depth attribute in RegularGrid to support 3D designs. - Refactored simulation domain calculations to utilize the new depth attribute. - Updated the simulation initialization to correctly determine if the design is 3D based on depth. - Added a test to verify that rasterized 2D grids are handled correctly in simulations.
- Removed the Medium class and updated references to use Material instead. - Cleaned up deprecated attributes and methods related to frequency flux spectrum in Monitor and Simulation classes. - Updated tests to reflect changes in the Monitor API and removed tests for deprecated features. - Enhanced documentation to clarify the new material handling approach.
This reverts commit 0520f5e.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GridSpec,GaussianPulse,ModeSpec,BoundarySpec,Box,FieldMonitor,FluxMonitor,ModeSolver, andModeData.Simulationconstruction with centereddomain/size, auto grid/time resolution, boundary specs, coordinate shifting, and copy/update helpers.ModeSources, and exposing mode monitor amplitudes as labeled xarray data.