Skip to content

Improve error message on missing rpc arguments #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dagurval wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve error message on missing rpc arguments #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 20 additions & 11 deletions bin/bcoin-cli
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,21 @@ class CLI {
}

async open() {

let print_usage = (err) => {
this.log(err);
this.log('Commands:');
this.log(' $ info: Get server info.');
this.log(' $ broadcast [tx-hex]: Broadcast transaction.');
this.log(' $ mempool: Get mempool snapshot.');
this.log(' $ tx [hash/address]: View transactions.');
this.log(' $ coin [hash+index/address]: View coins.');
this.log(' $ block [hash/height]: View block.');
this.log(' $ reset [height/hash]: Reset chain to desired block.');
this.log(' $ rpc [command] [args]: Execute RPC command.' +
' (`bcoin-cli rpc help` for more)');
}

switch (this.argv.shift()) {
case 'info':
await this.getInfo();
Expand All @@ -192,20 +207,14 @@ class CLI {
await this.reset();
break;
case 'rpc':
if (!this.argv.length) {
print_usage('Missing arguments');
break;
}
await this.rpc();
break;
default:
this.log('Unrecognized command.');
this.log('Commands:');
this.log(' $ info: Get server info.');
this.log(' $ broadcast [tx-hex]: Broadcast transaction.');
this.log(' $ mempool: Get mempool snapshot.');
this.log(' $ tx [hash/address]: View transactions.');
this.log(' $ coin [hash+index/address]: View coins.');
this.log(' $ block [hash/height]: View block.');
this.log(' $ reset [height/hash]: Reset chain to desired block.');
this.log(' $ rpc [command] [args]: Execute RPC command.' +
' (`bcoin-cli rpc help` for more)');
print_usage('Unrecognized command.');
break;
}
}
Expand Down