Restore deprecated functions that were removed in 3.2.0-dev (for backward compatibility).#6330
Closed
pocketarc wants to merge 69 commits intobcit-ci:developfrom
Closed
Restore deprecated functions that were removed in 3.2.0-dev (for backward compatibility).#6330pocketarc wants to merge 69 commits intobcit-ci:developfrom
pocketarc wants to merge 69 commits intobcit-ci:developfrom
Conversation
Signed-off-by: Bruno Moreira <bruno@terraduo.com>
* Adding PHP 8.2 support * Adds $uri prop in Router, and AllowDynamicProps attribute for CI_Controller * Adding missing `dest_image` property in CI_Image_lib --------- Co-authored-by: George Petculescu <gxgpet@gmail.com> Co-authored-by: George Petculescu <gxgpet@users.noreply.github.com>
# Conflicts: # readme.rst
Co-authored-by: Roger <roger.r.oliveira@unesp.br>
Due to PHP 8.2 deprecation of dynamic property creation, we can explicitly declare all _compile_* properties in the CI_Profiler class. These properties are known as they are created based on the $_available_sections array. This would be a clearer approach than just using #[AllowDynamicProperties]
timezones() can return either a specific timezone or the whole array.
…it the new release.
…patibility issues.
…. finfo_open() returns an finfo object (not a resource) since PHP 8.1, which is automatically freed when it goes out of scope. Fixes #34.
* Fixes XML-RPC compatibility with PHP 8 * Adds PHPUnit test for XML-RPC lib --------- Co-authored-by: George Petculescu <gxgpet@gmail.com>
…hange. The highlight_string() output format changed in PHP 8.3, not 8.4.
…ion, and downloads
…ty for backward compatibility.
…cation notice. Fix #41.
…notices in captcha_helper. Fix #40.
The open() method in Session_redis_driver returns $this->_success even when Redis::connect() fails (the else branch on a failed connection). This causes PHP's session_start() to believe the handler is ready, but subsequent read() calls fail, producing: session_start(): Failed to read session data: user (path: /var/lib/php/sessions) This was originally reported and fixed in the upstream bcit-ci/CodeIgniter repo: Issue: bcit-ci#5779 PR: bcit-ci#5781 The fix was merged into CI3 for the 3.1.11 milestone but appears to have been lost when the 3.2.0-dev branch was created, which this fork is based on. The fix changes the failed-connection else branch to log an error and fall through to return $this->_failure instead of incorrectly returning $this->_success.
Author
|
Closed, apologies - it was not my intention to raise it with upstream, just inside the fork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were several removals in 3.2.0-dev that forced users to change working code for no real benefit. Each is a trivial wrapper or alias with zero maintenance burden. Restoring them reduces friction for anyone migrating from CI 3.1.x to this fork.
We've reverted several of these in the past, but I wanted to go through the upgrade guide and reduce as many breaking changes as I could. This PR gets rid of a bunch of breaking changes.