-
Notifications
You must be signed in to change notification settings - Fork 0
add better support for multi-product archives (#2) #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pont-us
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a couple of nitpicks. Also, the readme needs to be updated.
I think we should merge the other, smaller PRs before this one, then we can deal with any conflicts when we update this branch from the new head of main.
Co-authored-by: Pontus Lurcock <[email protected]>
Co-authored-by: Pontus Lurcock <[email protected]>
Co-authored-by: Pontus Lurcock <[email protected]>
Co-authored-by: Pontus Lurcock <[email protected]>
Co-authored-by: Pontus Lurcock <[email protected]>
…_trees # Conflicts: # CHANGES.md # xarray_enmap/cli.py
Update arguments to process(), which had been overlooked in an earlier refactoring.
pont-us
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates. Approved!
Solves #2
As the CLI has not yet been published, we could apply more changes to make it more usable.