[gazelle] Allow other plugins to also contribute to class location#415
Open
shs96c wants to merge 3 commits into
Open
[gazelle] Allow other plugins to also contribute to class location#415shs96c wants to merge 3 commits into
shs96c wants to merge 3 commits into
Conversation
This allows plugins for other languages (such as a possible one for [Wire](https://square.github.io/wire/)) to contribute Java classes and packages to the dependency resolution.
6e231e4 to
65f296a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When multiple rules create a "split package", Gazelle needs class-level resolution to determine which rule provides which class. Previously, only the built-in Java plugin could participate in this resolution via the internal
classExportCache. Other gazelle plugins which generate java classes (such as a possible one for Wire) could not.This PR introduces a
SharedClassCacheinconfig.Extsthat external plugins can populate with their class information:The Java plugin's
buildPackageClassIndexnow consults both: