fix: sync database storage incrementally#357
Open
yanhao98 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
idtokey_idmappingWhy
The previous implementation rewrote every account on every save. With PostgreSQL and large token/JSON fields this creates large numbers of dead TOAST tuples. A production table with roughly 2,782 live accounts grew to approximately 109 GB, of which approximately 108 GB was TOAST, while the compacted live relation was only tens of MB.
Closes #355
Test plan
Result:
The repository-wide pytest invocation currently also collects integration scripts that require a running server and configured auth; those pre-existing tests fail locally with connection-refused/401 errors and are unrelated to this storage change.