Skip to content

Fix: Jetbrains rules were not working properly anymore#4150

Merged
dhh merged 1 commit intobasecamp:devfrom
NicolasDorier:fix-jetbrains-0.53
Jan 30, 2026
Merged

Fix: Jetbrains rules were not working properly anymore#4150
dhh merged 1 commit intobasecamp:devfrom
NicolasDorier:fix-jetbrains-0.53

Conversation

@NicolasDorier
Copy link
Copy Markdown
Contributor

@NicolasDorier NicolasDorier commented Jan 8, 2026

I have not been able to pinpoint what was the problem, but rewriting rules in the new style
is more beautiful and fixed my issue.

Note: I think this PR is ready to merge BUT there is still an issue documented in this comment.
But I think this is a problem that will be fixed in hyprland eventually, so this PR is probably ready to go as is.

Current workaround is to set the min_size to specific values (half of your monitor) min_size = 720 450

@NicolasDorier NicolasDorier marked this pull request as draft January 8, 2026 12:49
@NicolasDorier
Copy link
Copy Markdown
Contributor Author

NicolasDorier commented Jan 8, 2026

so fdee76e is problematic.
I was blaming @dhh vibe code on that.

But actually, the logic is correct min_size = (monitor_w*0.5) (monitor_h*0.5) is exactly what need to be done for fixing the popup.

Sadly, min_size doesn't support expressions. Thus the line is ignored. (And without warning)

image image

And changing to size is better, but still unusable.

image

Opened hyprwm/Hyprland#12936

@NicolasDorier NicolasDorier marked this pull request as ready for review January 8, 2026 14:28
@NicolasDorier
Copy link
Copy Markdown
Contributor Author

NicolasDorier commented Jan 22, 2026

Ping @dhh @ryanrhughes

This PR is ready to be merged IMHO

min_size expression support has been fixed by hyprland (hyprwm/Hyprland#12936), and will work as expected in the next version. (while not crashing in the current version)

I am currently using those rules with the commit that fixed it and jetbrains works like a charm.

@dhh dhh merged commit 3b94207 into basecamp:dev Jan 30, 2026
severin-richner pushed a commit to severin-richner/omarchy that referenced this pull request Feb 11, 2026
antonovch pushed a commit to antonovch/omarchy that referenced this pull request Feb 13, 2026
antonovch pushed a commit to antonovch/omarchy that referenced this pull request Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants