Skip to content

Add modelInputs width, height, num_inference_steps, guidance_scale#6

Open
gadicc wants to merge 1 commit into
bananaml:mainfrom
gadicc:main
Open

Add modelInputs width, height, num_inference_steps, guidance_scale#6
gadicc wants to merge 1 commit into
bananaml:mainfrom
gadicc:main

Conversation

@gadicc

@gadicc gadicc commented Sep 2, 2022

Copy link
Copy Markdown

What is this?

Passes on some common model inputs (width, height, num_inference_steps, guidance_scale).

Why?

They're useful :)

How did you test it?

Have been running locally in https://github.com/gadicc/stable-diffusion-react-nextjs-mui-pwa for a few days, and deployed.

Comments

  1. I have almost no Python experience, please comment on any styling / convention inconsistencies.
  2. I used the defaults I found online, not sure if there's a better way to allow empty values and let the model itself use its defaults.
  3. If this is all good I'll do the init_image and strength (iirc) stuff next when I get to that part of my app.

No urgency from my side, already running this deployed, but figured it would be useful for others.

@PNRxA

PNRxA commented Sep 9, 2022

Copy link
Copy Markdown

Argument positioning is wrong, Width changes the height. Needs a re-order or keyword arguments.

At least that's what happened when I tested locally

@gadicc

gadicc commented Sep 9, 2022

Copy link
Copy Markdown
Author

Ughhh thanks so much for reporting! 😅 Have fixed this now. Fixed the order AND switched to keyword arguments 😅 😅

@0xspeedrunner

Copy link
Copy Markdown

@gadicc are there plans to merge this / are you using this in prod for Kiri?

@gadicc

gadicc commented Oct 10, 2022

Copy link
Copy Markdown
Author

@0xspeedrunner, here's the full source for what we're using prod for kiri.art :)

https://github.com/gadicc/banana-sd-base

It's not as beginner friendly as this repo but feel free to open any issues there if anything is unclear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants