Conversation
Codecov Report
@@ Coverage Diff @@
## master #779 +/- ##
==========================================
+ Coverage 47.63% 47.69% +0.05%
==========================================
Files 133 133
Lines 6491 6498 +7
==========================================
+ Hits 3092 3099 +7
Misses 3399 3399
Continue to review full report at Codecov.
|
|
|
||
| private struct ModelUpdates { | ||
| struct ScrollPositionData { | ||
| let oldRect: CGRect |
There was a problem hiding this comment.
Just naming. Do you think it would make sense to name it just rect and the property holding this value would call it oldScrollPositionData
There was a problem hiding this comment.
What ScrollPositionData essentially contains is an old rect, and a new indexPath.
Should I rename referenceIndexPath to newIndexPath, what do you think?
There was a problem hiding this comment.
Ahh, got it. Let's keep it like this then 👍
| let changes = updates.changes | ||
| let layout = updates.layoutModel | ||
| let visibleCellsAreValid = self.visibleCellsAreValid(changes: updates.changes) | ||
| let wantsReloadData = updateType != .normal && updateType != .firstSync |
There was a problem hiding this comment.
should we do switch to enforce that we handle all possible new use cases?
| guard let self = self, let collectionView = collectionView else { return } | ||
|
|
||
| switch scrollAction { | ||
| case .scrollToBottom: |
There was a problem hiding this comment.
(Just to confirm) Is this not needed anymore?
3 participants
No description provided.