Add Ability for the quadratic skip#30
Open
vnikonov63 wants to merge 2 commits intomainfrom
Open
Conversation
Ask about opinion
ataha322
reviewed
May 9, 2026
| } | ||
| } | ||
|
|
||
| /* pub fn forward_seconds(model: &mut Model, seconds: u64) { |
Contributor
There was a problem hiding this comment.
it's fine to delete these if we're not using them
|
|
||
| fn handle_skip(model: &mut Model, direction: SkipDirection) { | ||
| const PRESS_GRACE: Duration = Duration::from_millis(250); | ||
| const STREAK_LEVELUP_COOLDOWN: Duration = Duration::from_millis(3000); |
Contributor
There was a problem hiding this comment.
what if we make this 0.5 or 1 sec instead of 3? it felt a bit slow when I was trying it out
| fn handle_skip(model: &mut Model, direction: SkipDirection) { | ||
| const PRESS_GRACE: Duration = Duration::from_millis(250); | ||
| const STREAK_LEVELUP_COOLDOWN: Duration = Duration::from_millis(3000); | ||
| const MAX_STREAK: u32 = 4; |
Contributor
There was a problem hiding this comment.
It felt like 4 is a bit slow, how about 16?
Collaborator
Author
There was a problem hiding this comment.
Adding 256 seconds at a time, it is nice :)
| "Current playback state [{:?}], popup [{:?}] <- Message [{:?}]", | ||
| model.app_state, model.popup, msg | ||
| ); | ||
| if msg != Message::Tick { |
Contributor
There was a problem hiding this comment.
it's okay to remove this debug log altogether
ataha322
reviewed
May 9, 2026
Contributor
ataha322
left a comment
ataha322
left a comment
There was a problem hiding this comment.
nice one, left a few comments
Collaborator
Author
|
Currently when we skip forward with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ask about opinion