fix(macOS): Thin Client入力パイプラインを安定化 - #345
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
プロセス分離後のmacOS入力処理を、ConverterServerが変換状態を一元管理するThin Client構成に整理し、入力遅延・入力漏れ・候補選択のフィードバックループを修正します。
あわせて、アプリに組み込んだConverterServerが署名・リソース・App Groupの問題で起動できないケースを修正します。
背景・原因
変更内容
InputSessionを削除し、テスト可能なルーティング処理をCoreへ移動Contents/Helpersへ配置し、必要なSwiftPMリソースの同梱、rpath、署名、App Groupパス解決を修正影響範囲
動作確認
swift test --package-path Core(63 tests passed)xcodebuild -project azooKeyMac.xcodeproj -scheme azooKeyMac -destination 'platform=macOS' -only-testing:azooKeyMacTests CODE_SIGNING_ALLOWED=NO test(9 tests passed)swiftlint lint --quiet --strict./install.sh --dry-run備考
入力内容を含み得るデバッグログの整理は、このPRには含めず別タスクで扱います。