Adds append_dimensions to collectd, supporting custom metric dimensions #1997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TravisStark
force-pushed
the
tjstark/collectd-append
branch
2 times, most recently
from
feba8d7 to
159ff44
Compare
TravisStark
added
the
ready for testing
TravisStark
force-pushed
the
tjstark/collectd-append
branch
2 times, most recently
from
cf9fcea to
8b8e009
Compare
TravisStark
force-pushed
the
tjstark/collectd-append
branch
from
8b8e009 to
addd131
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
Collectd plugin doesn't support append_dimensions, preventing users from adding custom dimensions to collectd metrics for fleet-level aggregation.
Description of changes
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Requirements
Before commiting your code, please do the following steps.
make fmtandmake fmt-shmake lintIntegration Tests
To run integration tests against this PR, add the
ready for testinglabel.