chore(claude-apps-gateway): track cdk/package-lock.json - #265
Open
bluedoors wants to merge 1 commit into
Open
Conversation
The lock file was never committed — an omission, not a decision: no .gitignore in this repo excludes lock files, and the sibling CDK app in the same gateway family (claude-apps-gateway-bootstrap/cdk) already tracks its own. Two things it buys: - Dependabot can remediate transitive CVEs. .github/dependabot.yml scans /** for npm with security updates enabled; without a lock it can only bump the direct ranges in package.json, leaving anything inside aws-cdk-lib's tree (321 resolved packages here) unfixable. - The documented verification gate becomes reproducible. CLAUDE.md leans on `npm install && npx cdk synth` plus `npm test` as the strongest automated check, but `aws-cdk-lib: ^2.260.0` resolves differently over time, so synth output and the 17 assertions could drift without any code change. Committed as generated — lockfileVersion 3, in sync with package.json (root deps match). The docs use `npm install`, never `npm ci`, so anyone who wants the latest resolution can still delete it and reinstall.
bsnehanshu
added a commit
to bsnehanshu/anthropic-on-aws
that referenced
this pull request
Jul 27, 2026
…, not apac Bedrock's geo cross-region inference profiles for Anthropic models use au (not apac) for Australia, and jp exists for Opus 4.8 and Haiku 4.5 but not Sonnet 5 — verified against the live Bedrock model cards. Every reference to apac. across CLAUDE.md, README.md, cdk/README.md, docs/deployment.md, cdk/gateway.yaml.template, cdk/gateway.yaml.example, and the cdk test comment was wrong. Also tracks cdk/package-lock.json, generated by npm install for this change (same rationale as aws-samples#265 — reproducible synth/test + Dependabot coverage of transitive deps).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Commits
claude-apps-gateway/cdk/package-lock.json, which had never been tracked.Why
This looks like an omission rather than a deliberate exclusion: no
.gitignorein the repo excludes lock files, and the sibling CDK app in the same gateway family —claude-apps-gateway-bootstrap/cdk— already tracks its own.Two concrete benefits:
.github/dependabot.ymlscans/**for npm with security updates enabled. Without a lock file it can only bump the direct ranges inpackage.json, leaving anything insideaws-cdk-lib's dependency tree (321 resolved packages here) unfixable. chore(deps): bump the npm-security group across 3 directories with 2 updates #260 shows the mechanism — it fixed CVEs by editingpackage.json+ lock-file pairs.claude-apps-gateway/CLAUDE.mdtreatsnpm install && npx cdk synthplusnpm testas the strongest automated check, butaws-cdk-lib: ^2.260.0resolves differently over time — synth output and the 17 assertions could drift with no code change.Notes
lockfileVersion: 3, in sync withpackage.json(rootdependencies/devDependenciesmatch exactly).npm install, nevernpm ci, so anyone who wants the latest resolution can still delete the lock and reinstall.Verification
Run from
claude-apps-gateway/cdk, resolving deps from the committed lock: