fix(idempotency): fix serialization of Pydantic idempotency keys for special data types#8066
Open
jontmy wants to merge 1 commit intoaws-powertools:developfrom
Open
fix(idempotency): fix serialization of Pydantic idempotency keys for special data types#8066jontmy wants to merge 1 commit intoaws-powertools:developfrom
jontmy wants to merge 1 commit intoaws-powertools:developfrom
Conversation
|
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Issue number: closes #8065
Summary
Changes
mode="json"instead of relying on the defaultmode="python"User experience
Before: Special data types such as UUID and dates cannot be used in idempotency keys because they cannot be serialized by Pydantic's default
.model_dump().After: Setting
mode="json"allows Pydantic to convert supported data types (such as UUIDs) to valid JSON values, allowing them to be used as part of idempotency keys. If an unsupported type is used and can't be serialized to JSON, a PydanticSerializationError exception is raised.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.