Skip to content

resolve name conflict on node-webkit#311

Open
yapcheahshen wants to merge 1 commit intoaurajs:masterfrom
yapcheahshen:master
Open

resolve name conflict on node-webkit#311
yapcheahshen wants to merge 1 commit intoaurajs:masterfrom
yapcheahshen:master

Conversation

@yapcheahshen
Copy link
Copy Markdown

use requirejs() instead of require() for running on node-webkit.

@sbellity
Copy link
Copy Markdown
Member

sbellity commented Sep 5, 2013

@yapcheahshen the tests seem to fail.

https://travis-ci.org/aurajs/aura/jobs/11012559

Can you fix this ?

Thanks !

@sbellity
Copy link
Copy Markdown
Member

sbellity commented Sep 5, 2013

@yapcheahshen Very curious to see it running on node-webkit !
Do you have a demo to share ;) ?

@yapcheahshen
Copy link
Copy Markdown
Author

i built this platform , write and test on node-webkit,
and deploy to server right away.
https://github.com/yapcheahshen/ksanapc

On Thu, Sep 5, 2013 at 7:54 PM, Stephane Bellity
notifications@github.comwrote:

@yapcheahshen https://github.com/yapcheahshen Very curious to see it
running on node-webkit !
Do you have a demo to share ;) ?


Reply to this email directly or view it on GitHubhttps://github.com//pull/311#issuecomment-23862239
.

@yapcheahshen
Copy link
Copy Markdown
Author

it seems like https://travis-ci.org/aurajs/aura/jobs/11012559 doesn't have "requirejs"
I am using RequireJS 2.0.2 with node-webkit,
on node-webkit, require() is node.js CommonJS ,
on browser side need to use requirejs() for AMD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants