Draft
Conversation
e336026 to
3683b3a
Compare
Collaborator
|
This is a non trivial issue and I'm investigating a fix as well. |
3683b3a to
d791eaf
Compare
espressif/esp-idf#9764 Signed-off-by: Peter M <petermm@gmail.com>
Guard the static putenv buffer workaround behind __NEWLIB__/__PICOLIBC__ so platforms with non-leaking libc (glibc, musl) use standard setenv/unsetenv. Picolibc (used by ESP-IDF 6) has the same setenv leak. Additional fixes: - Replace space-padding with zero-fill to avoid TZ parser issues - Reject oversized TZ values instead of silently truncating - Restore "UTC0" instead of empty string when TZ was originally unset - Check strdup for OOM, putenv return value, and localtime_r for NULL Signed-off-by: Peter M <petermm@gmail.com>
d791eaf to
d3169f4
Compare
Signed-off-by: Peter M <petermm@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2062
replicate:
And see rapidly decreasing free memory - solution inspired by espressif/esp-idf#9764
Currently in draft, as I believe there is some issue with setting the tz to "" on generic_unix - which means it is set to utc, just need to understand that or guard it..
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later