fix(build): exclude overlay files from javadoc and sourcesJar tasks#2322
Merged
fix(build): exclude overlay files from javadoc and sourcesJar tasks#2322
Conversation
The freefair lombok plugin uses afterEvaluate to set delombok's input to the source directories directly (not the filtered SourceDirectorySet FileTree), so the sourceSets exclude does not propagate to delombok. The overlay files (bare method fragments with no class/package/imports) then appear in the delombok output and cause 93 javadoc errors. Fix: add explicit excludes on the javadoc and sourcesJar tasks, which operate on the delombok output directory and support path-based excludes. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Chris (He/Him) <cgrote@gmail.com>
Signed-off-by: Chris (He/Him) <cgrote@gmail.com>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
afterEvaluateto wiredelombok.inputto the raw source directories (not the filteredSourceDirectorySetFileTree), sosourceSets["main"].java.exclude(...)is never seen by delombok_overlays/**) are bare method fragments (nopackage,import, orclasswrapper) — they end up in the delombok output and cause 93 javadoc errors:cannot find symbolandunnamed classes are a preview featureexclude("com/atlan/model/assets/_overlays/**")directly on thejavadocandsourcesJartasks, which operate on the delombok output directory and respect path-based excludesTest plan
🤖 Generated with Claude Code