Skip to content

Conversation

@matthi4s
Copy link
Member

No description provided.

@matthi4s matthi4s requested a review from Copilot February 11, 2026 14:40
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR focuses on small refactors/optimizations: simplifying object instantiation syntax, cleaning up unused imports, and replacing a couple of manual loops with higher-level array helper functions.

Changes:

  • Simplify new expressions by removing unnecessary parentheses in tests and the test driver.
  • Refactor test model to import GenericModel instead of using a fully qualified name.
  • Replace manual loop logic with array_all() / array_find() and remove unused use imports.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
test/tests/TestDriverTest.php Removes redundant parentheses around new in test fixtures.
test/tests/SQLTest.php Simplifies new SelectField(...) expressions in SQL query tests.
test/src/TestModel.php Switches to importing GenericModel for cleaner inheritance syntax.
src/Query/Generator/SQL.php Removes an unused UnexpectedValueException import.
src/Driver/Test/TestTableEntryGroup.php Refactors condition matching loop to array_all().
src/Driver/Test/TestTable.php Refactors entry lookup loop to array_find().
src/Driver/Test/TestDriver.php Removes redundant parentheses around new TestTableEntry(...).
src/Driver/Mysqli/MysqliException.php Removes an unused mysqli import.
src/Driver/Mysqli/Mysqli.php Minor import formatting cleanup.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@matthi4s matthi4s merged commit e97b2e9 into master Feb 11, 2026
3 checks passed
@matthi4s matthi4s deleted the code-quality branch February 11, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant