Add ModelCollection->getModels() to get the backing array of the collection#48
Closed
JulianVennen wants to merge 2 commits intomasterfrom
Closed
Add ModelCollection->getModels() to get the backing array of the collection#48JulianVennen wants to merge 2 commits intomasterfrom
JulianVennen wants to merge 2 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a convenience accessor to retrieve the underlying models array from ModelCollection, avoiding manual iteration/copying when callers need a plain array.
Changes:
- Documented the
$modelsproperty as a typed generic array (TModel[]). - Added
ModelCollection::getModels()to return the internal models array.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When selecting models, you often want to have an array of models at the end. ModelCollection exists because queries can return additional data like the number of rows that matched the filter or how long it took to execute the query.
To convert a model collection to an array you previously had to iterate over it and copy the elements into an array. Now you can just call
->getModels()instead.