Add metal config drive#1
Open
atd9876 wants to merge 5 commits into
Open
Conversation
Owner
Author
|
@copilot review this PR |
Signed-off-by: Andrew Dodds <andrew.dodds@sap.com>
Signed-off-by: Andrew Dodds <andrew.dodds@sap.com>
atd9876
force-pushed
the
add-metal-config-drive
branch
2 times, most recently
from
114170c to
bab4a01
Compare
- Use strings.Fields instead of strings.Split for proper whitespace handling - Use errors.Is for wrapped error comparison (context.DeadlineExceeded) - Rename local url variable to parsedURL to avoid shadowing net/url import - Check f.Close() error in test helper - Check url.Parse error in test assertion Signed-off-by: Andrew Dodds <andrew.dodds@sap.com>
atd9876
force-pushed
the
add-metal-config-drive
branch
from
bab4a01 to
a13e77b
Compare
- Return hard error on device timeout instead of silently continuing - Wrap os.Remove in logging closure for temp mount point cleanup - Add blackbox integration test for cmdline device/path config fetch Signed-off-by: Andrew Dodds <andrew.dodds@sap.com>
Convert silent failure paths in the cmdline provider to hard errors: - Return an error when only one of ignition.config.device and ignition.config.path is set, instead of logging a warning and continuing without config. - Return an error when the config file is not found on the specified device, instead of silently returning ErrEmpty. Add negative blackbox tests for both error paths: - cmdline.device.config.notfound: device exists but config file missing. - cmdline.device.notfound: specified device label does not exist. Signed-off-by: Andrew Dodds <andrew.dodds@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Local PR for copilot review