fix: handle wrapper errors with empty inner errors list#423
Merged
zachdaniel merged 1 commit intomainfrom Mar 20, 2026
Merged
Conversation
When Ash.Error.Forbidden (or Framework, Invalid, Unknown) is raised with no inner errors, to_json_api_errors flat-mapped over [] and produced zero JSON:API errors. This caused downstream code to proceed as if no error occurred, ultimately crashing with KeyError on missing :result assign. Add a guard (errors != []) to the wrapper-unwrapping clause so empty wrappers fall through to the catch-all, and add ToJsonApiError protocol implementations for the four wrapper types so they produce a proper error response. Closes #422
zachdaniel
approved these changes
Mar 20, 2026
Contributor
|
🚀 Thank you for your contribution! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #422
When
Ash.Error.Forbidden.exception([])(or any wrapper error with an empty inner errors list) is returned from a generic action,to_json_api_errorsflat-maps over[]and produces zero JSON:API errors. This causes the request pipeline to proceed as if no error occurred, ultimately crashing withKeyError: key :result not foundinfetch_includes.errors != []guard to the wrapper-unwrapping clause so empty wrappers fall through to the catch-allToJsonApiErrorprotocol implementations for the four wrapper error types (Forbidden,Framework,Invalid,Unknown)Ash.Error.Forbidden.exception([])Test plan