Refactor CSV Import command - #2381
Open
sbreker wants to merge 2 commits into
Open
Conversation
anvit
reviewed
Jul 13, 2026
| $commandUpdate = ('match-and-update' == $this->updateType) ? '--update="match-and-update"' : '--update="delete-and-replace"'; | ||
| $commandSkipUnmatched = ($this->skipUnmatched) ? '--skip-unmatched' : ''; | ||
| $commandLimit = ('' !== $this->limit) ? "--limit=\"{$this->limit}\"" : ''; | ||
| $commandLimit = ('' !== $this->limit) ? sprintf('--limit=%s', $this->limit) : ''; |
Contributor
There was a problem hiding this comment.
Do we not need these string arguments to be in quotes?
Member
Author
There was a problem hiding this comment.
You are correct. I missed adding escapeshellargs() here which returns a quoted string. See latest commit which addresses this.
sbreker
force-pushed
the
dev/refactor-csv-import-command
branch
from
July 16, 2026 22:18
1be66b9 to
337a412
Compare
sbreker
force-pushed
the
dev/refactor-csv-import-command
branch
from
July 16, 2026 22:20
337a412 to
d8a33b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.