Catch IndexError in DateTimeParser.parse for malformed format strings#1245
Open
karthiksai109 wants to merge 1 commit intoarrow-py:masterfrom
Open
Catch IndexError in DateTimeParser.parse for malformed format strings#1245karthiksai109 wants to merge 1 commit intoarrow-py:masterfrom
karthiksai109 wants to merge 1 commit intoarrow-py:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1245 +/- ##
==========================================
Coverage ? 100.00%
==========================================
Files ? 10
Lines ? 2318
Branches ? 358
==========================================
Hits ? 2318
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a malformed format string with certain bracket patterns is passed to DateTimeParser.parse, the bracket-escaping logic in _generate_pattern_re can strip out named groups from the final regex while still keeping those tokens in the token list. This causes match.group(token) to raise an IndexError instead of a proper ParserMatchError.
This wraps the match.group() calls in a try/except so that an IndexError from a missing group gets converted into a ParserMatchError, consistent with how other parse failures are reported.
Includes a regression test using the format string from the original report.
Fixes #1191