fix: Added type hint for start and end datetime for interval#1230
Open
inzamrzn918 wants to merge 5 commits intoarrow-py:masterfrom
Open
fix: Added type hint for start and end datetime for interval#1230inzamrzn918 wants to merge 5 commits intoarrow-py:masterfrom
inzamrzn918 wants to merge 5 commits intoarrow-py:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1230 +/- ##
==========================================
Coverage ? 100.00%
==========================================
Files ? 10
Lines ? 2315
Branches ? 358
==========================================
Hits ? 2315
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Author
|
@krisfremen , Can you please complete the review |
jadchaar
requested changes
Oct 18, 2025
Comment on lines
-740
to
+742
| :param end: (optional) A datetime expression, the end of the range. | ||
| :param start: A datetime or Arrow expression, the start of the range. | ||
| :param end: (optional) A datetime or Arrow expression, the end of the range. |
Member
There was a problem hiding this comment.
please add a test case using the Arrow object - are we properly handling it in the body?
Member
|
Had one comment - thanks for your contribution |
Member
|
Hi @inzamrzn918 mind adding a unit test? Then we can close this out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added type hint for start and end datetime for interval
Pull Request Checklist
Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:
toxormake testto find out!).tox -e lintormake lintto find out!).masterbranch.If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!
Description of Changes
This PR will fix issue "Closes: #1210", which is a bug related to type hint