Conversation
Co-Authored by: Lukas Lemke <90070416+13MK3@users.noreply.github.com>
Co-Authored by: Lukas Lemke <90070416+13MK3@users.noreply.github.com>
Co-Authored by: Lukas Lemke <90070416+13MK3@users.noreply.github.com>
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #1142 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 2319 2319
Branches 492 492
=========================================
Hits 2319 2319
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
krisfremen
left a comment
There was a problem hiding this comment.
LGTM for fixing up the link issue.
As far as the 'DDD' token, ISO8601 IIRC specified ordinal numbers that can also have leading zeros. So I think it should be left as is.
TestArrowHumanize::test_months is marked as xfail because we were running into issues with the limits in specific dates/times. it's something we should definitely look again into in the future.
|
This PR is awaiting what? 😢 |
Pull Request Checklist
Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:
toxormake testto find out!).tox -e lintormake lintto find out!).masterbranch.If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!
Description of Changes
These changes were made in collaboration with @khanm3
Closes: #1084
Questions: