Fix deprecated fpdf2 parameters in report renderers#332
Open
aligalipcamli wants to merge 1 commit into
Open
Conversation
Update Django Ledger PDF report renderers to avoid deprecated fpdf2 cell parameter usage. - Replace txt= with text= - Replace ln= with new_x=XPos.LMARGIN and new_y=YPos.NEXT - Preserve existing PDF rendering behavior - Verify PDF generation locally with parseable output using pypdf
aligalipcamli
force-pushed
the
fix/fpdf2-deprecated-report-params
branch
from
9aabb76 to
43d2212
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Django Ledger PDF report renderers to avoid deprecated fpdf2 cell parameter usage.
Replace txt= with text=
Replace ln= with new_x=XPos.LMARGIN and new_y=YPos.NEXT
Preserve existing PDF rendering behavior
Verify PDF generation locally with parseable output using pypdf
Note on target branch
I noticed the contribution guide mentions opening PRs against
develop. However,developcurrently appears to be behindmaster, while the latest release tags seem to be on themasterline. For that reason, I opened this small maintenance PR againstmaster.If you prefer this contribution to target
develop, I’m happy to retarget or rebase accordingly.Local validation
I validated the change in a small Django Ledger integration spike by generating financial statement PDFs and parsing the generated files with
pypdf.The smoke test checks that:
%PDFpypdf.PdfReaderDeprecationWarningis emitted during PDF report generationI also ran the local integration test suite successfully.