ci(lint): enforce var-naming[no-role-prefix] and production profile - #130
Merged
Conversation
There was a problem hiding this comment.
The lint-config change is correct and safe to merge.
- Removing
var-naming[no-role-prefix]fromskip_listis backed by the code: all role-scoped registers andset_factnames are properly prefixed (_tailscale_*,_alloy_*,alloy_ready,do_config_backups, …), the unprefixedvars:blocks (packages_keys,packages_list, …) all attach toansible.builtin.include_roletasks (excluded from the no-role-prefix check), and moleculeverify.ymlregisters live in playbooks rather than role task files. profile: production+strict: trueis a reasonable CI hardening.
Left one non-blocking nit: under strict: true, warnings fail CI, so the warn_list entries effectively behave like a fail_list. Worth a look but not a blocker.
Member
Author
|
Removed the |
The repository already satisfies the rule, so lifting it out of the skip list locks in the current state instead of fixing a defect. Signed-off-by: Simon Bärlocher <s.baerlocher@sbaerlocher.ch>
With `strict: true` ansible-lint exits non-zero on warnings as well, so the entries in `warn_list` act as a fail_list rather than as warnings. Both rules are meant to be enforced, so remove the misleading list. Signed-off-by: Simon Bärlocher <s.baerlocher@sbaerlocher.ch>
sbaerlocher
force-pushed
the
refactor/var-naming-role-prefix
branch
from
August 10, 2026 21:43
46db4d4 to
2b13716
Compare
sbaerlocher
enabled auto-merge (squash)
August 10, 2026 21:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
var-naming[no-role-prefix]from theskip_listand addprofile: productionplusstrict: trueto.ansible-lint.verify.ymlregisters sit at play level where the sub-rule cannot apply.Test plan
0 failure(s), 0 warning(s) on 121 filesvar-naming[pattern]var-naming[no-role-prefix]once the skip entry is removed, and passes silently while it is presentPassed: 0 failure(s), 0 warning(s) on 121 files. Profile 'production' was required, and it passed.yamllintclean on the changed file